Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] upload or create into folder Shares #5566

Merged
merged 6 commits into from
Aug 16, 2021
Merged

[tests-only] upload or create into folder Shares #5566

merged 6 commits into from
Aug 16, 2021

Conversation

ScharfViktor
Copy link
Contributor

A test is written that demonstrates the error. The test will work when the bug is fixed

Description here owncloud/ocis#2322

@ScharfViktor ScharfViktor requested a review from phil-davis July 25, 2021 22:14
@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/17643/46/1
The following scenarios passed on retry:

  • webUILogin/openidLogin.feature:29

@ownclouders
Copy link
Contributor

Results for oC10MoveUpload https://drone.owncloud.com/owncloud/web/17643/13/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/17645/38/1
The following scenarios passed on retry:

  • webUISharingExternal/federationSharing.feature:363

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/17645/64/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIFilesCopy-copy-feature-36.png

webUIFilesCopy-copy-feature-36.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

phil-davis
phil-davis reviewed Jul 26, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are good. This is interesting behavior and good to have tests for the current oC10 behavior. We need everybody to discuss in the issue what the behavior should be.

tests/acceptance/features/webUICreateFilesFolders/createFolders.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUICreateFilesFolders/createFolders.feature Outdated Show resolved Hide resolved
@ScharfViktor ScharfViktor changed the title upload or create into folder Shares [tests-only] upload or create into folder Shares Jul 26, 2021
@phil-davis
Copy link
Contributor

@ScharfViktor there is now a conflict with the other PR that was just merged. You need to rebase and sort that out.

phil-davis
phil-davis previously approved these changes Jul 26, 2021
View reviewed changes
@phil-davis phil-davis self-requested a review July 26, 2021 07:08
@phil-davis phil-davis dismissed their stale review July 26, 2021 07:08

still needs conflicts resolved

@ScharfViktor ScharfViktor mentioned this pull request Jul 26, 2021
Closed
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/17695/27/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/17695/51/1
The following scenarios passed on retry:

  • webUIMarkdownEditor/markdownFile.feature:19

@phil-davis
Copy link
Contributor

The test will work when the bug is fixed

The behavior might be a feature, and not need to be fixed.

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/17697/33/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/publicLinkIndicator.feature:27

@ownclouders
Copy link
Contributor

Results for oCISSharingInternalUsers1 https://drone.owncloud.com/owncloud/web/17783/54/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:108

phil-davis
phil-davis reviewed Jul 29, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests look good. Just a few suggestions for words in the scenario descriptions.

When you get .drone.star sorted out, we will see if the scenarios pass in CI.

.drone.star Show resolved Hide resolved
tests/acceptance/features/webUIOperationsWithFolderShares/accessToSharesFolder.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUIOperationsWithFolderShares/accessToSharesFolder.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUIOperationsWithFolderShares/accessToSharesFolder.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUIOperationsWithFolderShares/accessToSharesFolder.feature Outdated Show resolved Hide resolved
tests/acceptance/features/webUIOperationsWithFolderShares/accessToSharesFolder.feature Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

Results for oCISSharingPermissions2 https://drone.owncloud.com/owncloud/web/17802/57/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISResharing1 https://drone.owncloud.com/owncloud/web/17802/59/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17803/49/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17823/49/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingPublicExpireAndRoles https://drone.owncloud.com/owncloud/web/17839/61/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingPermissions2 https://drone.owncloud.com/owncloud/web/17839/57/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/17842/27/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

@owncloud owncloud deleted a comment from update-docs bot Aug 10, 2021
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/18126/24/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsToRootSharingIndicator/shareWithGroups.feature:104
  • webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:114

@ownclouders
Copy link
Contributor

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/18130/39/1
The following scenarios passed on retry:

  • webUISharingExternal/federationSharing.feature:363

@ownclouders
Copy link
Contributor

Results for oC10Locks https://drone.owncloud.com/owncloud/web/18130/8/1
The following scenarios passed on retry:

  • webUIWebdavLockProtection/move.feature:123

@phil-davis
Copy link
Contributor

I suggest that we rebase this after #5652 is merged - that PR will provide a known-good green CI to the latest oCIS 1.10.0

@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait2 https://drone.owncloud.com/owncloud/web/18230/43/1
The following scenarios passed on retry:

  • webUIMoveFilesFolders/moveFiles.feature:51

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic https://drone.owncloud.com/owncloud/web/18230/61/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:62

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18271/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18309/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/18309/52/1
The following scenarios passed on retry:

  • webUICreateFilesFolders/createFolderEdgeCases.feature:19

@ScharfViktor ScharfViktor changed the title [full-ci] [tests-only] upload or create into folder Shares [tests-only] upload or create into folder Shares Aug 16, 2021
@phil-davis
Copy link
Contributor

The linked drone build https://drone.owncloud.com/owncloud/web/18313/1/1 shows that it was cancelled after 5 seconds.
I have no idea why that happened.
I will restart it.

@ownclouders
Copy link
Contributor

Results for oC10iPhone1 https://drone.owncloud.com/owncloud/web/18321/45/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:59

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18321/40/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@phil-davis
Copy link
Contributor

The usual 0C10Basic pipeline that passes in CI has:

$ cucumber-js --retry 1 --require-module @babel/register --require-module @babel/polyfill --require tests/acceptance/setup.js --require tests/acceptance/stepDefinitions --format node_modules/cucumber-pretty tests/acceptance/features/webUIAccount tests/acceptance/features/webUILogin tests/acceptance/features/webUIPreview tests/acceptance/features/webUIPrivateLinks -t 'not @skip and not @skipOnOC10 and not @openIdLogin'

That has not @openIdLogin in the filter tags. Those tests are skipped when running against oC10.

But https://drone.owncloud.com/owncloud/web/18321/7/14 has only not @skipOnOC10 and not @notToImplementOnOC10 in the filter tags. So those OpenId test scenarios were being run.

I added a commit to fix that.

phil-davis
phil-davis requested changes Aug 16, 2021
View reviewed changes
nodesource_setup.sh Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersSharingIndicator https://drone.owncloud.com/owncloud/web/18335/28/1
The following scenarios passed on retry:

  • webUISharingInternalUsersToRootSharingIndicator/shareWithUsers.feature:98

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/18335/12/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor merged commit 4b56e5c into master Aug 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the uploadIntoShared branch August 16, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScharfViktor @ownclouders @phil-davis