Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Skip file deletion fail in public share #4897

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

haribhandari07
Copy link
Contributor

@haribhandari07 haribhandari07 commented Mar 31, 2021

Description

Skip failing scenarios for file deletion in public share. Deletion of multiple file fail with file locked error.
Also, scenarios with a batch deletion that are likely to fail have been skipped in order to make CI green.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets only use @skipOnOC10 I think they work fine on ocis

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14079/

20210331-073451-794.png
20210331-073508-181.png

@individual-it
Copy link
Member

next failure webUISharingPublic/shareByPublicLink.feature:825 with the same locking issue

@haribhandari07 haribhandari07 force-pushed the skip-file-deletion-fail branch from 5a71275 to 1b1d8e9 Compare March 31, 2021 07:46
@haribhandari07 haribhandari07 force-pushed the skip-file-deletion-fail branch from 981244a to 154fc13 Compare March 31, 2021 08:12
@dpakach
Copy link
Contributor

dpakach commented Mar 31, 2021

Isn't this issue intermittent, in that case, won't we have the same issue when it passes randomly?

@individual-it individual-it merged commit 1389176 into master Mar 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the skip-file-deletion-fail branch March 31, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants