Skip to content

Commit

Permalink
Merge pull request #4897 from owncloud/skip-file-deletion-fail
Browse files Browse the repository at this point in the history
[Tests-Only] Skip file deletion fail in public share
  • Loading branch information
individual-it authored Mar 31, 2021
2 parents 6027e07 + 154fc13 commit 1389176
Show file tree
Hide file tree
Showing 9 changed files with 23 additions and 22 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -226,11 +226,11 @@ Other free text and markdown formatting can be used elsewhere in the document if
- [webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:100](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature#L100)
- [webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:123](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature#L123)
- [webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:139](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature#L139)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:312](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L312)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:320](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L320)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:329](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L329)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:338](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L338)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:347](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L347)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:313](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L313)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:321](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L321)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:330](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L330)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:339](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L339)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:348](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L348)

### [[OCIS] declining a received share gives 500 error even if the share is declined](https://github.com/owncloud/product/issues/276)
- [webUISharingAcceptShares/acceptShares.feature:124](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L124)
Expand Down Expand Up @@ -336,10 +336,10 @@ Other free text and markdown formatting can be used elsewhere in the document if

### [Adjust web UI test scenarios that demonstrate fixed bugs](https://github.com/owncloud/web/issues/4601)
- [webUISharingPublic/shareByPublicLink.feature:795](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublic/shareByPublicLink.feature#L795)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:123](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L123)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:299](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L299)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:276](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L276)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:213](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L213)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:124](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L124)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:300](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L300)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:277](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L277)
- [webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:214](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature#L214)

### [renamed file cannot be shared](https://github.com/owncloud/web/issues/4192)
- [webUISharingInternalUsers/shareWithUsers.feature:570](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature#L570)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ Feature: deleting files and folders
| "question?" |
| "&and#hash" |

@smokeTest @skip
@smokeTest @skipOnOC10 @issue-4582
Scenario: Delete multiple files at once
When the user batch deletes these files using the webUI
| name |
Expand All @@ -63,7 +63,7 @@ Feature: deleting files and folders
And the deleted elements should not be listed on the webUI after a page reload
And no message should be displayed on the webUI


@skipOnOC10 @issue-4582
Scenario: Delete all files at once
When the user marks all files for batch action using the webUI
And the user batch deletes the marked files using the webUI
Expand All @@ -75,7 +75,7 @@ Feature: deleting files and folders



@ocis-reva-issue-106 @ocis-reve-issue-442
@ocis-reva-issue-106 @ocis-reve-issue-442 @skipOnOC10 @issue-4582
Scenario: Delete all except for a few files at once
When the user marks all files for batch action using the webUI
And the user unmarks these files for batch action using the webUI
Expand Down Expand Up @@ -183,7 +183,7 @@ Feature: deleting files and folders
| question? |
| &and#hash |

@skip @yetToImplement
@skip @yetToImplement @issue-4582
Scenario: Delete multiple files at once on a public share
Given user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions
When the public uses the webUI to access the last public link created by user "Alice"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ Feature: accept/decline shares coming from internal users
Then file "lorem (2).txt" shared by "Alice Hansen" should be in "Declined" state on the webUI
And file "testimage.jpg" shared by "Alice Hansen" should be in "Pending" state on the webUI

@issue-3101 @skip
@issue-3101 @skip @issue-4582
Scenario: Delete multiple accepted shares at once from shared with me page
Given the setting "shareapi_auto_accept_share" of app "core" has been set to "no"
And user "Alice" has been created with default attributes
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ Feature: Sharing files and folders with internal users
And the user browses to the folder "Shares" on the files page
Then folder "simple-folder" should not be listed on the webUI

@issue-ocis-730
@issue-ocis-730 @skipOnOC10 @issue-4582
Scenario: deleting multiple entries on the shared-with-me page
Given user "Alice" has shared folder "simple-folder" with user "Brian"
And user "Brian" has accepted the share "simple-folder" offered by user "Alice"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ Feature: Sharing files and folders with internal users
And the user browses to the files page
Then folder "simple-folder (2)" should not be listed on the webUI


@skipOnOC10 @issue-4582
Scenario: deleting multiple entries on the shared-with-me page
Given user "Alice" has shared folder "simple-folder" with user "Brian"
And user "Alice" has shared file "lorem.txt" with user "Brian"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ Feature: Share by public link
Then folder "public-created-folder" should be listed on the webUI
And as "Alice" folder "/simple-folder/public-created-folder" should exist


@skipOnOC10 @issue-4582
Scenario: public batch deletes resources in the public link
Given user "Alice" has created a public link with following settings
| path | /simple-folder |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ Feature: Share by public link with different roles
When the public uses the webUI to access the last public link created by user "Alice"
Then there should be no resources listed on the webUI


@skipOnOC10 @issue-4582
Scenario: creating a public link with "Editor" role makes it possible to delete files via the link
Given user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions
When the public uses the webUI to access the last public link created by user "Alice"
Expand All @@ -101,6 +101,7 @@ Feature: Share by public link with different roles
Then the deleted elements should not be listed on the webUI
And the deleted elements should not be listed on the webUI after a page reload

@skipOnOC10 @issue-4582
Scenario: creating a public link with "Editor" role makes it possible to delete files via the link even with password set
Given user "Alice" has shared folder "simple-folder" with link with "read, update, create, delete" permissions and password "pass123"
When the public uses the webUI to access the last public link created by user "Alice" with password "pass123"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Feature: files and folders can be deleted from the trashbin
When the user deletes folder "Folder,With,Comma" using the webUI
Then folder "Folder,With,Comma" should not be listed on the webUI


@skipOnOC10 @issue-4582
Scenario: Select some files and delete from trashbin in a batch
When the user batch deletes these files using the webUI
| name |
Expand All @@ -62,7 +62,7 @@ Feature: files and folders can be deleted from the trashbin
And file "lorem.txt" should not be listed on the webUI
And file "lorem-big.txt" should not be listed on the webUI

@issue-product-188
@issue-product-188 @skipOnOC10 @issue-4582
Scenario: Select all except for some files and delete from trashbin in a batch
When the user marks all files for batch action using the webUI
And the user unmarks these files for batch action using the webUI
Expand All @@ -89,7 +89,7 @@ Feature: files and folders can be deleted from the trashbin
But folder "simple-folder" should be listed on the webUI
And file "data.zip" should not be listed on the webUI

@issue-product-188
@issue-product-188 @skipOnOC10 @issue-4582
Scenario: Select all files and delete from trashbin in a batch
When the user marks all files for batch action using the webUI
And the user batch deletes the marked files using the webUI
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Feature: files and folders exist in the trashbin after being deleted
| &and#hash |
| sämple,1.txt |

@skipOnOCIS @issue-product-186
@skipOnOCIS @issue-product-186 @skipOnOC10 @issue-4582
Scenario: Delete multiple files at once and check that they are all in the trashbin
When the user batch deletes these files using the webUI
| name |
Expand Down

0 comments on commit 1389176

Please sign in to comment.