Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] tests to demonstrate issue #720 #722

Merged
merged 2 commits into from
Oct 22, 2020

Conversation

individual-it
Copy link
Member

  1. fix the description in the expected failures files why apiShareManagementBasicToShares/deleteShareFromShares.feature:43 & :44 fail
  2. extend the bug-demonstration scenario to make sure it fails if share receiver gets ERROR 500 on any PROPFIND after the sharer deletes the collaborator  #720 get fixed

@individual-it individual-it self-assigned this Oct 20, 2020
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/776/15/7

  @issue-ocis-720 @issue-ocis-721
  Scenario Outline: delete a share                                                                  # /drone/src/ocis/tests/acceptance/features/apiOcisSpecific/apiShareManagementBasic-deleteShare.feature:6
    Given user "Alice" has been created with default attributes and without skeleton files          # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And user "Alice" has uploaded file with content "ownCloud test text file 0" to "/textfile0.txt" # FeatureContext::userHasUploadedAFileWithContentTo()
    And user "Brian" has been created with default attributes and without skeleton files            # FeatureContext::userHasBeenCreatedWithDefaultAttributesAndWithoutSkeletonFiles()
    And using OCS API version "<ocs_api_version>"                                                   # FeatureContext::usingOcsApiVersion()
    And user "Alice" has shared file "textfile0.txt" with user "Brian"                              # FeatureContext::userHasSharedFileWithUserUsingTheSharingApi()
    And user "Brian" has accepted share "/textfile0.txt" offered by user "Alice"                    # FeatureContext::userHasReactedToShareOfferedBy()
    When user "Alice" deletes the last share using the sharing API                                  # FeatureContext::userDeletesLastShareUsingTheSharingApi()
    Then the OCS status code should be "<ocs_status_code>"                                          # OCSContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"                                                        # FeatureContext::thenTheHTTPStatusCodeShouldBe()
    And as "Brian" file "/Shares/textfile0.txt" should exist                                        # FeatureContext::asFileOrFolderShouldExist()

    Examples:
      | ocs_api_version | ocs_status_code |
      | 1               | 100             |
        file '/Shares/textfile0.txt' expected to exist for user Brian but not found
        Failed asserting that false is true.
      | 2               | 200             |
        file '/Shares/textfile0.txt' expected to exist for user Brian but not found
        Failed asserting that false is true.

The bug-demo is failing to demo the bug.

@individual-it
Copy link
Member Author

need to retest locally on OCIS storage

@individual-it
Copy link
Member Author

on ocis-storage the etag is not quoted, that's why the test-code does not "see" the file

@individual-it individual-it force-pushed the testDemonstrateIssue720 branch from f613279 to 0e56edd Compare October 22, 2020 03:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit af39720 into master Oct 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the testDemonstrateIssue720 branch October 22, 2020 06:44
ownclouders pushed a commit that referenced this pull request Oct 22, 2020
Merge: adc6055 c31dd9e
Author: Phil Davis <phil@jankaritech.com>
Date:   Thu Oct 22 12:29:46 2020 +0545

    Merge pull request #722 from owncloud/testDemonstrateIssue720

    [tests-only] tests to demonstrate issue #720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants