Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] new env. variable to set how files/folders are provisioned for tests #691

Merged
merged 1 commit into from
Oct 13, 2020
Merged

[tests-only] new env. variable to set how files/folders are provisioned for tests #691

merged 1 commit into from
Oct 13, 2020

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Oct 13, 2020 •
edited
Loading

using new switch from owncloud/core#38005 to decides how to provision the skeleton folder

tests pass, except one flaky MOVE test, see owncloud/product#249

@individual-it individual-it mentioned this pull request Oct 13, 2020
Merged
11 tasks
@individual-it individual-it self-assigned this Oct 13, 2020
@individual-it individual-it force-pushed the skeletonStrategySwitch branch from b52e0a6 to 2b0e5fd Compare October 13, 2020 05:47
@individual-it individual-it force-pushed the skeletonStrategySwitch branch from 2b0e5fd to bb108eb Compare October 13, 2020 09:08
@individual-it individual-it marked this pull request as ready for review October 13, 2020 10:04
@individual-it individual-it mentioned this pull request Oct 13, 2020
Closed
micbar
micbar approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/580/25/7

unsh: Total unexpected passed scenarios throughout the test run:
apiWebdavEtagPropagation1/moveFileFolder.feature:58

The "random pass" happened again.
Restarting drone...

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis mentioned this pull request Oct 13, 2020
Closed
@phil-davis phil-davis merged commit 4bdfdd0 into master Oct 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the skeletonStrategySwitch branch October 13, 2020 12:06
ownclouders pushed a commit that referenced this pull request Oct 13, 2020
@phil-davis
commit 4bdfdd0
d7fbc81 
Merge: fa2531c bb108eb
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Oct 13 17:51:36 2020 +0545

    Merge pull request #691 from owncloud/skeletonStrategySwitch

    [tests-only] new env. variable to set how files/folders are provisioned for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@micbar micbar micbar approved these changes

Assignees

@individual-it individual-it

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@individual-it @phil-davis @micbar