Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust creating skeleton folder and user data deletion for API tests when using OCIS-storage #223

Closed
individual-it opened this issue Sep 11, 2020 · 4 comments · Fixed by owncloud/core#38005
Assignees

Comments

@individual-it
Copy link
Member

when using OCIS storage and creating a user, we cannot just dump files into the folder to emulate the skeleton folder as we do with the OC storage but we need to upload the items via WebDav.

to delete data of the user after deleting the user our current delete strategy does not work, (https://github.com/owncloud/core/blob/828f07802fa3b977fcdbf315f9671d5442288886/tests/TestHelpers/OcisHelper.php#L68) we have to use a delete command

To accomplish both that we have currently to set

'TEST_OCIS':'true'
'OCIS_REVA_DATA_ROOT':''
'DELETE_USER_DATA_CMD':'rm -rf /srv/app/tmp/ocis/root/nodes/root/*'

see https://github.com/owncloud/ocis-reva/pull/466/files#diff-74dc60589e0610c07e491b31f8693b2bR112-R129

it would be better to simplify that, maybe have an other setting like REVA_STORAGE_OC_DRIVER and according to that deleteRevaUserData will delete the correct folder and choose to upload the skeleton via WebDAV

@phil-davis
Copy link

Needs some thought/discussion about the flow/configuration of env variables etc.

@individual-it
Copy link
Member Author

Alternative approach: leave the deletion as it is and make a new switch for the skeleton provisioning strategy: owncloud/core#38005

@phil-davis
Copy link

When we next bump the core commit id for tests in OCIS, we should define OCIS_SKELETON_STRATEGY to be "copy" (if that works), otherwise define it to be "upload".

@individual-it
Copy link
Member Author

@phil-davis the change of env variables is done in owncloud/ocis#691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants