Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci][tests-only] Bump core commit id for tests #2674

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Oct 25, 2021

Description

Bump core commit id to the latest for the tests.

Related Issue

Part of owncloud/QA#693

How Has This Been Tested?

  • test environment:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Oct 25, 2021
@saw-jan saw-jan force-pushed the bump-commit-id-20211025 branch from 1dd9ba1 to af9c381 Compare October 25, 2021 11:30
@saw-jan
Copy link
Member Author

saw-jan commented Oct 25, 2021

[do-not-merge] blocked by PR owncloud/core#39414

@saw-jan saw-jan force-pushed the bump-commit-id-20211025 branch from af9c381 to 64ba7dd Compare October 25, 2021 11:33
@saw-jan saw-jan force-pushed the bump-commit-id-20211025 branch from 64ba7dd to 80e4a75 Compare October 25, 2021 11:47
@saw-jan saw-jan force-pushed the bump-commit-id-20211025 branch from 21e5af2 to 9abb45a Compare October 26, 2021 04:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan marked this pull request as ready for review October 26, 2021 04:49
@saw-jan saw-jan requested a review from phil-davis October 26, 2021 04:50
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: the extra test fails are because the test code has been improved.
theDownloadedContentForMultipartByterangeShouldBe test method now has the int type declared for the expected $statusCode which is correct. Previously the "number" came as a string.

		if ($actualStatusCode === $statusCode) {
			$actualContent = (string) $this->response->getBody();
...

In current guzzle 7 (used for the acceptance test) getStatusCode() also returns an int. So now the strict comparison matches, and the content is being checked and reported.

Previously status code (string) "206" did not match actual status code (int) 206, so the test code did not think that a 206 really happened, and so did not check the detailed multi-part content.

@phil-davis phil-davis merged commit 2e8b160 into master Oct 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-commit-id-20211025 branch October 26, 2021 05:31
ownclouders pushed a commit that referenced this pull request Oct 26, 2021
Merge: 25d6e4e 9abb45a
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Oct 26 11:16:40 2021 +0545

    Merge pull request #2674 from owncloud/bump-commit-id-20211025

    [full-ci][tests-only] Bump core commit id for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants