Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Fix return type of function getFileIdForPath #39414

Merged
merged 1 commit into from
Oct 25, 2021
Merged

[tests-only] Fix return type of function getFileIdForPath #39414

merged 1 commit into from
Oct 25, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Oct 25, 2021 •
edited
Loading

Description

oCIS returns fileId as string

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@saw-jan saw-jan self-assigned this Oct 25, 2021
@saw-jan saw-jan mentioned this pull request Oct 25, 2021
Merged
9 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis marked this pull request as ready for review October 25, 2021 14:50
@phil-davis phil-davis merged commit 4d7d5a1 into master Oct 25, 2021
@phil-davis phil-davis deleted the fix-return-types branch October 25, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saw-jan @phil-davis