[docs-only] Update settings source strings for translation #10835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmattel
force-pushed
the
notification_strings_fixes
branch
from
e9ac8ef to
ca8d01a
Compare
|
LukasHirt
reviewed
Jan 8, 2025
| @@ -7,43 +7,43 @@ var ( | |||
| // name of the notification option 'Share Received' | |||
| TemplateShareCreated = l10n.Template("Share Received") | |||
| // description of the notification option 'Share Received' | |||
| TemplateShareCreatedDescription = l10n.Template("Notify me when I receive a share") | |||
| TemplateShareCreatedDescription = l10n.Template("Notify when I have received a share") | |||
There was a problem hiding this comment.
Do we even need here the Notify when...? Maybe something like Received a share would be sufficient?
There was a problem hiding this comment.
This is the image with the old data for ease of understanding the layout:
kobergj
approved these changes
Jan 9, 2025
ownclouders
pushed a commit
that referenced
this pull request
Jan 9, 2025
[docs-only] Update settings source strings for translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References: #10812 (Notification Option Translations)
As discussed with @kobergj, some translation sources need an update to be correct