Notification Option Translations #10812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kobergj
force-pushed
the
NotificationSettingTranslations
branch
from
5c110ec to
3f08258
Compare
kobergj
commented
Dec 30, 2024
|
@mmattel could you have a look on docs/translations stuff? |
kobergj
force-pushed
the
NotificationSettingTranslations
branch
2 times, most recently
from
4d1a98c to
1cc7f02
Compare
kobergj
force-pushed
the
NotificationSettingTranslations
branch
3 times, most recently
from
0e17477 to
43945c1
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
NotificationSettingTranslations
branch
from
43945c1 to
02a53ca
Compare
mmattel
reviewed
Jan 2, 2025
| @@ -38,6 +38,7 @@ type Config struct { | |||
| ServiceAccountIDs []string `yaml:"service_account_ids" env:"SETTINGS_SERVICE_ACCOUNT_IDS;OCIS_SERVICE_ACCOUNT_ID" desc:"The list of all service account IDs. These will be assigned the hidden 'service-account' role. Note: When using 'OCIS_SERVICE_ACCOUNT_ID' this will contain only one value while 'SETTINGS_SERVICE_ACCOUNT_IDS' can have multiple. See the 'auth-service' service description for more details about service accounts." introductionVersion:"5.0"` | |||
|
|
|||
| DefaultLanguage string `yaml:"default_language" env:"OCIS_DEFAULT_LANGUAGE" desc:"The default language used by services and the WebUI. If not defined, English will be used as default. See the documentation for more details." introductionVersion:"5.0"` | |||
| TranslationPath string `yaml:"translation_path" env:"OCIS_TRANSLATION_PATH;SETTINGS_TRANSLATION_PATH" desc:"(optional) Set this to a path with custom translations to overwrite the builtin translations. Note that file and folder naming rules apply, see the documentation for more details." introductionVersion:"7.0"` | |||
There was a problem hiding this comment.
This cant be introductionVersion:"7.0".
It either must be 7.0.0 (full semver, requires backporting to 7.0) or %%NEXT%%, which is a placeholder/identifyer for a real release to be fixed before published. See Introduce new Envvars for more details.
|
Doc text looks ok. |
kobergj
force-pushed
the
NotificationSettingTranslations
branch
from
48adecb to
02a53ca
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
kobergj
force-pushed
the
NotificationSettingTranslations
branch
from
02a53ca to
dd4b168
Compare
|
2403905
approved these changes
Jan 8, 2025
ownclouders
pushed a commit
that referenced
this pull request
Jan 8, 2025
Notification Option Translations
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translates the notification settings. See 'Epic' for details https://github.com/owncloud/enterprise/issues/6715#issuecomment-2501163144
fixes #10803