Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] extend webdav tests for old, new and spaces path #10516

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Nov 8, 2024

Description

This PR extends the test scenarios that use Webdav API to cover all available dav path versions (i.e. old, new and spaces).

Build check for both configs (with and without remote.php):

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya force-pushed the extend-webdav-test-for-all-paths branch 3 times, most recently from 58cd43e to 98445d8 Compare November 15, 2024 11:15
@PrajwolAmatya PrajwolAmatya force-pushed the extend-webdav-test-for-all-paths branch 2 times, most recently from 6abf15a to 076c92f Compare November 18, 2024 03:35
@PrajwolAmatya PrajwolAmatya force-pushed the extend-webdav-test-for-all-paths branch from 8bf3f29 to 21c7b86 Compare November 18, 2024 10:52
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@PrajwolAmatya
Copy link
Contributor Author

PrajwolAmatya commented Nov 19, 2024

After addressing reviews, some line numbers have changed so running CI with and without remote.php in dav path. Only merge after all the pipelines are green.
Build check: https://drone.owncloud.com/owncloud/ocis/41176
For this check there are changes in drone file. Need to revert the changes back before merging this PR.

@PrajwolAmatya PrajwolAmatya force-pushed the extend-webdav-test-for-all-paths branch 3 times, most recently from 092eff8 to d14f074 Compare November 19, 2024 06:29
@PrajwolAmatya PrajwolAmatya force-pushed the extend-webdav-test-for-all-paths branch from d14f074 to 9d6bd35 Compare November 19, 2024 07:20
@PrajwolAmatya PrajwolAmatya merged commit 32bafde into master Nov 19, 2024
4 checks passed
@PrajwolAmatya PrajwolAmatya deleted the extend-webdav-test-for-all-paths branch November 19, 2024 08:17
ownclouders pushed a commit that referenced this pull request Nov 19, 2024
[tests-only][full-ci] extend webdav tests for old, new and spaces path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants