Skip to content

Commit

Permalink
extend dav paths versions
Browse files Browse the repository at this point in the history
  • Loading branch information
PrajwolAmatya committed Nov 18, 2024
1 parent 076c92f commit 21c7b86
Show file tree
Hide file tree
Showing 14 changed files with 109 additions and 382 deletions.
3 changes: 1 addition & 2 deletions tests/acceptance/expected-failures-API-on-OCIS-storage.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ Synchronization features like etag propagation, setting mtime and locking files
- [coreApiTrashbin/trashbinSharingToShares.feature:144](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiTrashbin/trashbinSharingToShares.feature#L144)
- [coreApiTrashbin/trashbinSharingToShares.feature:202](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiTrashbin/trashbinSharingToShares.feature#L202)
- [coreApiTrashbin/trashbinSharingToShares.feature:203](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiTrashbin/trashbinSharingToShares.feature#L203)
- [coreApiTrashbin/trashbinSharingToShares.feature:204](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiTrashbin/trashbinSharingToShares.feature#L204)

### Other

Expand Down Expand Up @@ -154,7 +153,7 @@ _ocdav: api compatibility, return correct status code_

#### [Trying to delete other user's trashbin item returns 409 for spaces path instead of 404](https://github.com/owncloud/ocis/issues/9791)

- [coreApiTrashbin/trashbinDelete.feature:97](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiTrashbin/trashbinDelete.feature#L97)
- [coreApiTrashbin/trashbinDelete.feature:92](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/coreApiTrashbin/trashbinDelete.feature#L92)

#### [MOVE a file into same folder with same name returns 404 instead of 403](https://github.com/owncloud/ocis/issues/1976)

Expand Down
3 changes: 1 addition & 2 deletions tests/acceptance/expected-failures-without-remotephp.md
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,7 @@
- [apiSpaces/publicLink.feature:40](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/publicLink.feature#L40)
- [apiSpacesShares/shareSpacesViaLink.feature:61](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpacesShares/shareSpacesViaLink.feature#L61)
- [apiDepthInfinity/propfind.feature:74](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiDepthInfinity/propfind.feature#L74)
- [apiDepthInfinity/propfind.feature:140](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiDepthInfinity/propfind.feature#L140)
- [apiDepthInfinity/propfind.feature:141](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiDepthInfinity/propfind.feature#L141)
- [apiDepthInfinity/propfind.feature:124](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiDepthInfinity/propfind.feature#L124)
- [apiLocks/lockFiles.feature:490](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiLocks/lockFiles.feature#L490)
- [apiLocks/lockFiles.feature:487](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiLocks/lockFiles.feature#L487)
- [apiLocks/lockFiles.feature:488](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiLocks/lockFiles.feature#L488)
Expand Down
6 changes: 0 additions & 6 deletions tests/acceptance/features/apiAntivirus/antivirus.feature
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,6 @@ Feature: antivirus
| old | eicar_com.zip | virusFile2.zip |
| new | eicar.com | virusFile1.txt |
| new | eicar_com.zip | virusFile2.zip |
| spaces | eicar.com | virusFile1.txt |
| spaces | eicar_com.zip | virusFile2.zip |


Scenario Outline: upload a file with virus to a user share using spaces dav endpoint
Expand Down Expand Up @@ -223,8 +221,6 @@ Feature: antivirus
| old | eicar_com.zip | virusFile2.zip |
| new | eicar.com | virusFile1.txt |
| new | eicar_com.zip | virusFile2.zip |
| spaces | eicar.com | virusFile1.txt |
| spaces | eicar_com.zip | virusFile2.zip |


Scenario Outline: upload a file with virus to a group share using spaces dav endpoint
Expand Down Expand Up @@ -433,7 +429,6 @@ Feature: antivirus
| dav-path-version |
| old |
| new |
| spaces |


Scenario: try to overwrite a file with the virus content in group share using spaces dav endpoint
Expand Down Expand Up @@ -497,7 +492,6 @@ Feature: antivirus
| dav-path-version |
| old |
| new |
| spaces |


Scenario: try to overwrite a file with the virus content in user share using spaces dav endpoint
Expand Down
9 changes: 1 addition & 8 deletions tests/acceptance/features/apiDepthInfinity/propfind.feature
Original file line number Diff line number Diff line change
Expand Up @@ -117,28 +117,22 @@ Feature: PROPFIND with depth:infinity
| simple-folder/simple-folder1/simple-folder2/welcome.txt |
Examples:
| dav-path-version |
| old |
| new |
| spaces |

@issue-10331
Scenario Outline: get the list of resources in a folder shared through public link with depth infinity when depth infinity is not allowed
Scenario: get the list of resources in a folder shared through public link with depth infinity when depth infinity is not allowed
Given the following configs have been set:
| config | value |
| OCDAV_ALLOW_PROPFIND_DEPTH_INFINITY | false |
| OCIS_SHARING_PUBLIC_SHARE_MUST_HAVE_PASSWORD | false |
And using <dav-path-version> DAV path
And using SharingNG
And user "Alice" has created the following resource link share:
| resource | simple-folder |
| space | Personal |
| permissionsRole | view |
When the public lists the resources in the last created public link with depth "infinity" using the WebDAV API
Then the HTTP status code should be "400"
Examples:
| dav-path-version |
| new |
| spaces |


Scenario Outline: get the list of files in the trashbin with depth infinity when depth infinity is not allowed
Expand All @@ -153,6 +147,5 @@ Feature: PROPFIND with depth:infinity
Then the HTTP status code should be "400"
Examples:
| dav-path-version |
| old |
| new |
| spaces |
30 changes: 20 additions & 10 deletions tests/acceptance/features/apiSharingNg1/listPermissions.feature
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,8 @@ Feature: List a sharing permissions


Scenario: user lists permissions of a project space
Given user "Brian" has been created with default attributes and without skeleton files
Given using spaces DAV path
And user "Brian" has been created with default attributes and without skeleton files
And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
When user "Alice" lists the permissions of space "new-space" using permissions endpoint of the Graph API
Expand Down Expand Up @@ -289,7 +290,8 @@ Feature: List a sharing permissions

@issues-8352
Scenario Outline: sharer lists permissions of a shared project space
Given user "Brian" has been created with default attributes and without skeleton files
Given using spaces DAV path
And user "Brian" has been created with default attributes and without skeleton files
And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
And user "Alice" has sent the following space share invitation:
Expand Down Expand Up @@ -1040,7 +1042,8 @@ Feature: List a sharing permissions


Scenario: try to lists the permissions of a Personal drive using root endpoint
Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
Given using spaces DAV path
And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
When user "Alice" tries to list the permissions of space "Personal" using root endpoint of the Graph API
Then the HTTP status code should be "200"
Expand Down Expand Up @@ -1161,7 +1164,8 @@ Feature: List a sharing permissions


Scenario: try to lists the permissions of a Shares drive using root endpoint
Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
Given using spaces DAV path
And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
When user "Alice" tries to list the permissions of space "Shares" using root endpoint of the Graph API
Then the HTTP status code should be "200"
Expand All @@ -1184,7 +1188,8 @@ Feature: List a sharing permissions


Scenario: space admin invites to a project space with all allowed roles
Given the administrator has assigned the role "Admin" to user "Alice" using the Graph API
Given using spaces DAV path
And the administrator has assigned the role "Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
And user "Brian" has been created with default attributes and without skeleton files
When user "Alice" lists the permissions of space "new-space" using permissions endpoint of the Graph API
Expand All @@ -1211,7 +1216,8 @@ Feature: List a sharing permissions


Scenario: non-member user tries to list the permissions of a project space using permissions endpoint
Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
Given using spaces DAV path
And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Brian" has been created with default attributes and without skeleton files
And user "Alice" has created a space "new-space" with the default quota using the Graph API
When user "Brian" tries to list the permissions of space "new-space" owned by "Alice" using permissions endpoint of the Graph API
Expand Down Expand Up @@ -1267,7 +1273,8 @@ Feature: List a sharing permissions


Scenario: try to list the permissions of other user's personal space
Given user "Brian" has been created with default attributes and without skeleton files
Given using spaces DAV path
And user "Brian" has been created with default attributes and without skeleton files
When user "Brian" tries to list the permissions of space "Personal" owned by "Alice" using permissions endpoint of the Graph API
Then the HTTP status code should be "404"
And the JSON data of the response should match
Expand Down Expand Up @@ -1306,7 +1313,8 @@ Feature: List a sharing permissions


Scenario Outline: sharer lists permissions of a shared project space using root endpoint
Given user "Brian" has been created with default attributes and without skeleton files
Given using spaces DAV path
And user "Brian" has been created with default attributes and without skeleton files
And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
And user "Alice" has sent the following space share invitation:
Expand Down Expand Up @@ -1582,7 +1590,8 @@ Feature: List a sharing permissions


Scenario: user sends share invitation with all allowed roles for a project space using root endpoint
Given the administrator has assigned the role "Admin" to user "Alice" using the Graph API
Given using spaces DAV path
And the administrator has assigned the role "Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
And user "Brian" has been created with default attributes and without skeleton files
When user "Alice" lists the permissions of space "new-space" using root endpoint of the Graph API
Expand All @@ -1594,7 +1603,8 @@ Feature: List a sharing permissions

@issue-9151
Scenario: non-member user tries to list the permissions of a project space using root endpoint
Given the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
Given using spaces DAV path
And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Brian" has been created with default attributes and without skeleton files
And user "Alice" has created a space "new-space" with the default quota using the Graph API
When user "Brian" tries to list the permissions of space "new-space" owned by "Alice" using root endpoint of the Graph API
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,7 @@ Feature: sharing
And as "Brian" folder "/Shares/merge-test-inside-twogroups-perms (2)" should not exist


Scenario Outline: merging shares for recipient when shared from outside with group then user and recipient renames in between
Given using <dav-path-version> DAV path
Scenario: merging shares for recipient when shared from outside with group then user and recipient renames in between
And user "Alice" has created folder "/merge-test-outside-groups-renamebeforesecondshare"
# Section 1: Brian receives and accepts the group share from Alice and moves and renames it out of the "Shares" folder
When user "Alice" shares folder "/merge-test-outside-groups-renamebeforesecondshare" with group "grp1" using the sharing API
Expand All @@ -127,15 +126,9 @@ Feature: sharing
And the HTTP status code of responses on all endpoints should be "200"
And as "Brian" folder "/Shares/merge-test-outside-groups-renamebeforesecondshare" should exist
But as "Brian" folder "/merge-test-outside-groups-renamebeforesecondshare-renamed" should not exist
Examples:
| dav-path-version |
| old |
| new |
| spaces |


Scenario Outline: merging shares for recipient when shared from outside with user then group and recipient renames in between
Given using <dav-path-version> DAV path
Scenario: merging shares for recipient when shared from outside with user then group and recipient renames in between
And user "Alice" has created folder "/merge-test-outside-groups-renamebeforesecondshare"
# Section 1: Brian receives and accepts the user share from Alice and moves and renames it out of the "Shares" folder
When user "Alice" shares folder "/merge-test-outside-groups-renamebeforesecondshare" with user "Brian" using the sharing API
Expand All @@ -153,8 +146,3 @@ Feature: sharing
And the HTTP status code of responses on all endpoints should be "200"
And as "Brian" folder "/Shares/merge-test-outside-groups-renamebeforesecondshare" should exist
But as "Brian" folder "/merge-test-outside-groups-renamebeforesecondshare-renamed" should not exist
Examples:
| dav-path-version |
| old |
| new |
| spaces |
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@ Feature: accessing a public link share
Then the HTTP status code of responses on all endpoints should be "200"

@issue-web-10473
Scenario Outline: user tries to download public link file using own basic auth
Given using <dav-path-version> DAV path
And user "Alice" has created folder "FOLDER"
Scenario: user tries to download public link file using own basic auth
Given user "Alice" has created folder "FOLDER"
And user "Alice" has uploaded file "filesForUpload/textfile.txt" to "FOLDER/textfile.txt"
And using SharingNG
And user "Alice" has created the following resource link share:
Expand All @@ -80,7 +79,3 @@ Feature: accessing a public link share
| password | %public% |
When user "Alice" tries to download file "textfile.txt" from the last public link using own basic auth and new public WebDAV API
Then the HTTP status code should be "401"
Examples:
| dav-path-version |
| new |
| spaces |
12 changes: 0 additions & 12 deletions tests/acceptance/features/coreApiTrashbin/trashbinDelete.feature
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ Feature: files and folders can be deleted from the trashbin
And as "Alice" the file with original path "<file-name-2>" should not exist in the trashbin
Examples:
| dav-path-version | file-name | file-name-2 |
| old | textfile0.txt | textfile1.txt |
| old | sample,0.txt | sample,1.txt |
| new | textfile0.txt | textfile1.txt |
| new | sample,0.txt | sample,1.txt |
| spaces | textfile0.txt | textfile1.txt |
Expand All @@ -48,7 +46,6 @@ Feature: files and folders can be deleted from the trashbin
And as "Alice" the file with original path "/PARENT/CHILD/child.txt" should exist in the trashbin
Examples:
| dav-path-version |
| old |
| new |
| spaces |

Expand All @@ -72,7 +69,6 @@ Feature: files and folders can be deleted from the trashbin
And as "Alice" the file with original path "/PARENT/child.txt" should exist in the trashbin
Examples:
| dav-path-version |
| old |
| new |
| spaces |

Expand All @@ -92,7 +88,6 @@ Feature: files and folders can be deleted from the trashbin
And as "Alice" the file with original path "/PARENT/CHILD/child.txt" should exist in the trashbin
Examples:
| dav-path-version |
| old |
| new |
| spaces |

Expand All @@ -112,7 +107,6 @@ Feature: files and folders can be deleted from the trashbin
And as "Alice" the file with original path "/PARENT/CHILD/child.txt" should exist in the trashbin
Examples:
| dav-path-version |
| old |
| new |
| spaces |

Expand All @@ -132,7 +126,6 @@ Feature: files and folders can be deleted from the trashbin
And as "Alice" the file with original path "/PARENT/CHILD/child.txt" should exist in the trashbin
Examples:
| dav-path-version |
| old |
| new |
| spaces |

Expand All @@ -154,7 +147,6 @@ Feature: files and folders can be deleted from the trashbin
And as "Alice" the file with original path "/FOLDER/CHILD/child.txt" should exist in the trashbin
Examples:
| dav-path-version |
| old |
| new |
| spaces |

Expand All @@ -176,7 +168,6 @@ Feature: files and folders can be deleted from the trashbin
And as "Alice" the file with original path "/FOLDER/CHILD/child.txt" should exist in the trashbin
Examples:
| dav-path-version |
| old |
| new |
| spaces |

Expand Down Expand Up @@ -210,7 +201,6 @@ Feature: files and folders can be deleted from the trashbin
| # %ab ab?=ed.txt |
Examples:
| dav-path-version |
| old |
| new |
| spaces |

Expand Down Expand Up @@ -244,7 +234,6 @@ Feature: files and folders can be deleted from the trashbin
| # %ab ab?=ed |
Examples:
| dav-path-version |
| old |
| new |
| spaces |

Expand Down Expand Up @@ -290,6 +279,5 @@ Feature: files and folders can be deleted from the trashbin
| /fo.exe |
Examples:
| dav-path-version |
| old |
| new |
| spaces |
Loading

0 comments on commit 21c7b86

Please sign in to comment.