Extend test coverage for ocm

[amrita-shrestha]

Description

OCM setup : https://owncloud.dev/ocis/development/testing/#running-test-suite-with-federated-sharing-ocm
Future Federated space concept #10065

Done

• check activities on external shared resource
  • share with federated ocis user
    • resource at Personal drive
      • Comment: Extend test coverage for ocm #10073 (comment)
    • resource at Spaces
      • [tests-only][full-ci] add test to share project drive's resource to a federated user #10264
    • Share space:
      • Bug: OCM. Prevent federated users from being added as members of the space #10051
      • [tests-only][full-ci] test: Test coverage for bug #10051 #10203
      • [test-only] add federated users to space #10166
      • [tests-only][full-ci] refactor test to add federated user as a member of a project space using permissions endpoint #10379
• list externally shared shares - /permissions endpoint
  • Bug: Permissions endpoint is not listing federated shares #9898
  • [tests-only][full-ci] add test to list permissions of a resource shared to a federated user #10294
• list externally shared shares
  • Bug: [OCM] SharedByMe / SharedWithOthers is missing resources that have been shared externally #9908
  • [tests-only][full-ci] add test to list shares shared to federated user #10290
• check that federated user can upload files.
  • Related Bug: OCM. federated user gets a server crash when uploading files via tus #10285
  • (upload not fixed) : [QA] OCM: upload into received federated folder shows an error #10305 (comment)
  • [tests-only][full-ci] add test to upload file to a shared folder via TUS by federated user #10415
• Open a shared file as share receiver @nirajacharya2
  • Bug: OCM cannot open shared file #10358
  • [tests-only][full-ci] adding test for editing shared file(OCM) by the share receiver #10523
• list external sharewithme @nirajacharya2
  • Bug: OCM. user loses the first share #10222
    • [tests-only][full-ci] adding test coverage for sharing file with ocm #10565
  • check mimetype
    • Bug: OCM. user cannot see the thumbnails of the shared image file #10495)
    • [tests-only][full-ci] update test to check mimetype of federated share image file #10691

     "file": {
       "mimeType": "image/png"
     },
     "remoteIten": {
       "file": {
         "mimeType": "image/png"
       }
    }

• delete ocm connection
  • [test-only] delete connection tests #10224
• delete ocm connection after share
  • Bug: OCM. server crash after deleting share for ocm user #10213
  • [test-only] delete connection tests #10224
• download thumbnail from ocm share
  • Bug: OCM. user cannot see the thumbnails of the shared image file #10495
  • [tests-only][full-ci] add tests to download thumbnail preview of a federated share image #10651
• download file/folders as (archive) from ocm share
  • From: [QA] OCM - images (& thumbnails) are completely broken with OCM #10272 (comment)
  • [tests-only][full-ci] add test to download files and folders as archive by ocm user #10740
• share copied folder to federated user
  • Bug: OCM. user loses the shared folder that was copied #10488
  • [tests-only][full-ci] add test to share copied folder to remote user #10710
• update ocm share:
  • Bug: federated shares cannot be updated (sharing role / expiry date) #9926
    ocm. user cannot change share role web#11991
  • [tests-only][full-ci] add test for federated user trying to update shared file after local user updates role #10754
• remove access to share:
  • Bug: [OCM] federation shares missing name and root.remoteItem values in the drives list #10689
  • [tests-only][full-ci] add tests to remove access of shared resource to federated user #10672
• list me/drives and check that federation shares doesn't get listed
  • From: [OCM] federation shares missing name and root.remoteItem values in the drives list #10689 (comment)
  • [tests-only][full-ci] add test to list drives by federation user #10753
• check oc:share-types property of federated shared resource
  • Bug: OCM. Removing a federated share does not update the resource's share-types #10262
  • [tests-only][full-ci]added test for checking share-types property of shared resource shared to federated user #10929

• refactor multiple when steps
  • From comment here => [tests-only][full-ci] add test to share project drive's resource to a federated user #10264 (comment)
  • [tests-only][full-ci] refactor multiple when steps in OCM tests #10626

[prashant-gurung899]

• share with federated ocis user
  - resource at Personal drive

@saw-jan
I think test for sharing personal drive's resource to a federated user is covered by following scenario:

ocis/tests/acceptance/features/apiOcm/share.feature

Line 12 in d70c210

Scenario Outline: local user shares resources to federation user

Can you confirm?Or do we need more coverage.

[saw-jan]

yes, that's correct

[nirajacharya2]

Ive added a point at the end of the issue list.

[prashant-gurung899]

• delete ocm share (bug: OCM. server crash after deleting share for ocm user #10213)
• check if [test-only] delete connection tests #10224 has covered it or not

The PR: #10224 has covered tests for listing the shares after deleting the connections but not after removing the access to the share.
I have added tests for removing access to the share here: #10672

CC @saw-jan

[prashant-gurung899]

Closing this issue.
I have created a new one for test coverage of OCM bugs here: #10971

CC @PrajwolAmatya @saw-jan @amrita-shrestha @nirajacharya2