Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Cleanup good scenario for trashbinRestore issue-35974 #38869

Merged
merged 1 commit into from
Jun 21, 2021
Merged

[tests-only] Cleanup good scenario for trashbinRestore issue-35974 #38869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions tests/acceptance/features/apiTrashbin/trashbinRestore.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,15 +101,7 @@ Feature: Restore deleted files/folders
And user "Alice" has deleted file <delete-path>
When user "Alice" restores the file with original path <delete-path> to <upload-path> using the trashbin API
Then the HTTP status code should be "204"
# Sometimes <upload-path> is found in the trashbin. Should it? Or not?
# That seems to be what happens when the restore-overwrite happens properly,
# The original <upload-path> seems to be "deleted" and so goes to the trashbin
And as "Alice" the file with original path <upload-path> should not exist in the trashbin
And as "Alice" file <upload-path> should exist
# sometimes the restore from trashbin does overwrite the existing file, but sometimes it does not. That is also surprising.
# the current observed behavior is that if the original <upload-path> ended up in the trashbin,
# then the new <upload-path> has the "file to delete" content.
# otherwise <upload-path> has its old content
And the content of file <upload-path> for user "Alice" should be "file to delete"
Examples:
| dav-path | upload-path | delete-path |
Expand Down