[tests-only] Cleanup good scenario for trashbinRestore issue-35974

[phil-davis]

Description

This scenario is supposed to describe the desired good behavior when restoring a file to an already existing path. The existing file should be over-written with the content of the restored file.

There happens to be another side-effect on oC10 - the original file (sometimes) gets put into the trashbin. That side-effect has not been decided to be "required behavior". Maybe the original file should end up in the trashbin, maybe it should be available as an old version of the file, or maybe it should just be thrown away.

This PR removes the check "file should not exist in the trashbin". That makes the scenario suitable as a test for implementations, for example OCIS.

See more notes and discussion in #38867 and cs3org/reva#1795

Related Issue

• Restore file from trashbin to a different place overwriting a file #35974

How Has This Been Tested?

CI

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[phil-davis]

@dpakach it will be good to get this merged into core, and to get the core commit id updated in reva and ocis. Then they will have a better "good" scenario to work with as they sort out fixing trashbin issues.