Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user profile picture boolean to capabilities #38722

Merged
merged 1 commit into from
May 11, 2021

Conversation

pascalwengerter
Copy link
Contributor

Description

Adds another boolean to the capabilities

Related Issue

Motivation and Context

Needed for the new web frontend to know whether to fetch&render avatar profile pictures

Please review with care, I'm not a PHP dev!

@CLAassistant
Copy link

CLAassistant commented May 10, 2021

CLA assistant check
All committers have signed the CLA.

@phil-davis
Copy link
Contributor

We usually add new capabilites to https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiCapabilities/capabilities.feature test scenarios, similar to the way it is done at line 107.

Do you want me to add?

@pascalwengerter
Copy link
Contributor Author

:x

We usually add new capabilites to https://github.com/owncloud/core/blob/master/tests/acceptance/features/apiCapabilities/capabilities.feature test scenarios, similar to the way it is done at line 107.

Do you want me to add?

Great idea @phil-davis , please go ahead and do so (this will also restart the pipeline which should actually pass, timed out on the last run)

@phil-davis phil-davis force-pushed the add-profile-picture-capability branch from 0a44c69 to 8685cc3 Compare May 10, 2021 14:38
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise 👍 Just the PR-link in the changelog

changelog/unreleased/38721 Outdated Show resolved Hide resolved
@phil-davis phil-davis force-pushed the add-profile-picture-capability branch from 8685cc3 to 4418879 Compare May 11, 2021 11:25
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Communicate capability of showing user avatar images
4 participants