Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] respect capability for Avatar support #8758

Closed
michaelstingl opened this issue Jun 18, 2021 · 1 comment
Closed

[FEATURE REQUEST] respect capability for Avatar support #8758

michaelstingl opened this issue Jun 18, 2021 · 1 comment
Assignees
@erikjv
Labels
Early-Adopter:CERN p2-high Escalation, on top of current planning, release blocker
Milestone
2.10

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented Jun 18, 2021 •
edited by TheOneRing
Loading

There’s a new capability for Avatar support:

For web UI, motivation was mostly performance in the frontend. Seems backend performance and the plenty useless 404’s in the logs is just a cosmetic issue, not a real problem.

Capabilities: https://github.com/owncloud/client/blob/2.9/src/libsync/capabilities.cpp
AvatarJob: https://github.com/owncloud/client/blob/2.9/src/libsync/networkjobs.cpp#L583

Avatar jobs are started in two places once, in the connection validator https://github.com/owncloud/client/blob/2.9/src/gui/connectionvalidator.cpp#L290 and https://github.com/owncloud/client/blob/2.9/src/src/gui/shareusergroupwidget.cpp#L468

The connection validator is the critical one:

TODO:

  • Handle the capability
  • Don't start AvatarJob if the capability is disabled
  • Add assert to AvatarJob to ensure we handle the case
@michaelstingl michaelstingl added the p3-medium Normal priority label Jun 18, 2021
@michaelstingl michaelstingl added this to the Backlog milestone Jun 18, 2021
@michaelstingl michaelstingl added p4-low Low priority and removed p3-medium Normal priority labels Jun 18, 2021
@michaelstingl michaelstingl modified the milestones: Backlog, 2.9.2 Oct 4, 2021
@michaelstingl michaelstingl added p2-high Escalation, on top of current planning, release blocker and removed p4-low Low priority labels Oct 4, 2021
erikjv added a commit that referenced this issue Oct 6, 2021
@erikjv
Do not try to (repeatedly) fetch profile pictures when not available
ba3cd71 
The server has a capability to indicate that profile pictures (avatars)
are not available. Previously, the client would try to fetch them no
matter what, and even retry when the server responded with a 404. Now
we take the server capability into account, and do not try to fetch
those when not available.

Fixes: #8758
@erikjv erikjv mentioned this issue Oct 6, 2021
Merged
erikjv added a commit that referenced this issue Oct 7, 2021
@erikjv
Do not try to (repeatedly) fetch profile pictures when not available
da2f97d 
The server has a capability to indicate that profile pictures (avatars)
are not available. Previously, the client would try to fetch them no
matter what, and even retry when the server responded with a 404. Now
we take the server capability into account, and do not try to fetch
those when not available.

Fixes: #8758
TheOneRing pushed a commit that referenced this issue Oct 7, 2021
@erikjv @TheOneRing
Do not try to (repeatedly) fetch profile pictures when not available
88c4661 
The server has a capability to indicate that profile pictures (avatars)
are not available. Previously, the client would try to fetch them no
matter what, and even retry when the server responded with a 404. Now
we take the server capability into account, and do not try to fetch
those when not available.

Fixes: #8758
@TheOneRing
Copy link
Contributor

#9127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
Early-Adopter:CERN p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
2.10
Development

No branches or pull requests
4 participants
@erikjv @TheOneRing @michaelstingl @SamuAlfageme