Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] [nomerge] dedicated reva test suite changes #37798

Closed
wants to merge 1 commit into from

Conversation

butonic
Copy link
Member

@butonic butonic commented Aug 10, 2020

Currently, reva implements the ocs api, but we are moving it to ocis-ocs.

Some of the changes make endpoints return different statuscodes. To unblock other PRs in reva we will use this branch until the testuite there has moved to cs3 grpc api based testing. This PR is used to make the changes visible.

It is a subset of #37754

Affected PRs:

at least we no longer get an error response whan listing shares
@butonic
Copy link
Member Author

butonic commented Aug 10, 2020

pinging @individual-it and @phil-davis to double check the approach makes sense to them as well.

@individual-it
Copy link
Member

👍 LGTM. we even could merge this here as the tests in other repos are bound to a commitid

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #37798 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37798   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19392    19392           
=========================================
  Files          1284     1284           
  Lines         75755    75755           
  Branches       1333     1333           
=========================================
  Hits          49057    49057           
  Misses        26306    26306           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.94% <ø> (ø) 19392.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0932eac...dd8260e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #37798 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37798   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19392    19392           
=========================================
  Files          1284     1284           
  Lines         75755    75755           
  Branches       1333     1333           
=========================================
  Hits          49057    49057           
  Misses        26306    26306           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.94% <ø> (ø) 19392.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0932eac...dd8260e. Read the comment docs.

@phil-davis phil-davis changed the title [nomerge] dedicated reva test suite changes [Tests-Only] [nomerge] dedicated reva test suite changes Aug 10, 2020
@owncloud owncloud deleted a comment from update-docs bot Aug 10, 2020
@phil-davis
Copy link
Contributor

Something is stuck in codecov ??? It says it is "in progress" but no result.

@phil-davis
Copy link
Contributor

As @individual-it says, we can merge this. And actually PR cs3org/reva#1036 is waiting for merge and that gives local control of the core API test scenarios ffor cs3org/reva

The same has already been done in owncloud/ocis-reva.

The same is waiting in owncloud/ocis#427 because we did not want to cause confusion with the current efforts to get owncloud/ocis updated. (But maybe it will make life easier in owncloud/ocis by merging that?)

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed today lets not merge this but apply the system of owncloud/ocis#427
also waiting for owncloud/ocis#439

@codecov
Copy link

codecov bot commented Dec 12, 2020

Codecov Report

Merging #37798 (dd8260e) into master (efe5284) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37798   +/-   ##
=========================================
  Coverage     64.75%   64.75%           
  Complexity    19392    19392           
=========================================
  Files          1284     1284           
  Lines         75755    75755           
  Branches       1333     1333           
=========================================
  Hits          49057    49057           
  Misses        26306    26306           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
javascript 54.03% <ø> (ø) 0.00 <ø> (ø)
phpunit 65.94% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0932eac...dd8260e. Read the comment docs.

@phil-davis
Copy link
Contributor

codecov suddenly posted a report!!!???

@butonic is this PR still relevant to anything?

@butonic
Copy link
Member Author

butonic commented Jun 25, 2021

I guess this is outdated

@butonic butonic closed this Jun 25, 2021
@butonic butonic deleted the reva-tests branch June 25, 2021 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants