-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests-Only] [nomerge] dedicated reva test suite changes #37798
Conversation
at least we no longer get an error response whan listing shares
pinging @individual-it and @phil-davis to double check the approach makes sense to them as well. |
👍 LGTM. we even could merge this here as the tests in other repos are bound to a commitid |
Codecov Report
@@ Coverage Diff @@
## master #37798 +/- ##
=========================================
Coverage 64.75% 64.75%
Complexity 19392 19392
=========================================
Files 1284 1284
Lines 75755 75755
Branches 1333 1333
=========================================
Hits 49057 49057
Misses 26306 26306
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #37798 +/- ##
=========================================
Coverage 64.75% 64.75%
Complexity 19392 19392
=========================================
Files 1284 1284
Lines 75755 75755
Branches 1333 1333
=========================================
Hits 49057 49057
Misses 26306 26306
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Something is stuck in codecov ??? It says it is "in progress" but no result. |
As @individual-it says, we can merge this. And actually PR cs3org/reva#1036 is waiting for merge and that gives local control of the core API test scenarios ffor The same has already been done in The same is waiting in owncloud/ocis#427 because we did not want to cause confusion with the current efforts to get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as discussed today lets not merge this but apply the system of owncloud/ocis#427
also waiting for owncloud/ocis#439
Codecov Report
@@ Coverage Diff @@
## master #37798 +/- ##
=========================================
Coverage 64.75% 64.75%
Complexity 19392 19392
=========================================
Files 1284 1284
Lines 75755 75755
Branches 1333 1333
=========================================
Hits 49057 49057
Misses 26306 26306
Partials 392 392
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
codecov suddenly posted a report!!!??? @butonic is this PR still relevant to anything? |
I guess this is outdated |
Currently, reva implements the ocs api, but we are moving it to ocis-ocs.
Some of the changes make endpoints return different statuscodes. To unblock other PRs in reva we will use this branch until the testuite there has moved to cs3 grpc api based testing. This PR is used to make the changes visible.
It is a subset of #37754
Affected PRs: