Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Using or importing the ABCs from 'collections' instead of from … #98

Closed
wants to merge 1 commit into from

Conversation

fmdl
Copy link

@fmdl fmdl commented Aug 27, 2021

…'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…'collections.abc' is deprecated since Python 3.3, and in 3.10 it will stop working
@fmdl
Copy link
Author

fmdl commented Aug 27, 2021

ping @rbeuque74

Copy link
Member

@rbeuque74 rbeuque74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thank you for your contribution.

Would you mind bumping completely the requests vendor library instead of patching a single line?
We didn't bump requests for a while, and it could be a good idea to stay in line with the latest version.

Thanks
Romain

@fmdl
Copy link
Author

fmdl commented Sep 2, 2021

@rbeuque74 can you explain what I will do excatly ?

@Cajuteq
Copy link

Cajuteq commented Oct 18, 2021

Hi, as original requester of #96 thank you for taking the time,
Also I think @rbeuque74 is asking for a complete review and update of the calls to requests although I don't understand why because this fix is about collections.
Also I tried to check which version of the dependencies are used and ended up without finding any requirements.txt and with pip show ovh showing no dependencies.
Maybe documenting and updating dependencies could be the point of another merge request ? Leaving it to you guys, thanks again

@rbeuque74
Copy link
Member

Hello,
Sorry for the delay.

Per #108, I removed the vendoring of requests.
Hence, this problem is now gone.

Thanks for the report,
Closing, per #108.

@rbeuque74 rbeuque74 closed this Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants