Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation in collections call #96

Closed
Cajuteq opened this issue Jun 17, 2021 · 4 comments
Closed

Deprecation in collections call #96

Cajuteq opened this issue Jun 17, 2021 · 4 comments
Milestone

Comments

@Cajuteq
Copy link

Cajuteq commented Jun 17, 2021

Hi, using python3.9 with poetry, I found out running pytest that the collections call used in ovh are deprecated and will stop working with 3.10

[...] lib/python3.9/site-packages/ovh/vendor/requests/packages/urllib3/_collections.py:2: DeprecationWarning: 
Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, 
and in 3.10 it will stop working
    from collections import Mapping, MutableMapping

-- Docs: https://docs.pytest.org/en/stable/warnings.html

PyPI currently says ovh package is compatible with at most python3.6 which according to https://www.python.org/dev/peps/pep-0494/ will stop being updated on 2021-12.

Is there any work on making this package compatible with newer python version. It would be good to be able to continue using it under Python 3.10 !

@fmdl
Copy link

fmdl commented Aug 27, 2021

#98

@tirkarthi
Copy link

There are several other places where this is present : https://github.com/ovh/python-ovh/search?q=collections

@rbeuque74
Copy link
Member

Hello,
Sorry for the delay,
This issue will be fixed in v1.0.0.

@rbeuque74 rbeuque74 added this to the v1.0.0 milestone Mar 14, 2022
@rbeuque74
Copy link
Member

Fixed with #108.
Released in https://github.com/ovh/python-ovh/releases/tag/v1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants