feat: upgrade to v1 plugin API #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
force-pushed
the
regisb/plugin-v1
branch
from
1f530af to
f4b468d
Compare
kdmccormick
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
Looks good, pending myservice->lms fix.
Things I was able to do successfully:
tutor plugins disable mfe && tutor plugins enable mfe && tutor config savetutor images pull(MFE image was skipped, as expected)tutor images build mfetutor local quickstart, as well astutor local init --limit=mfe- Viewing the Demo Course's course outline and dates pages in the Learning MFE.
- Viewing my account settings and profile pages in their MFEs.
- Viewing the Gradebook MFE.
What didn't work:
- Courseware gives me an opaque "There was an error loading this course." message, with no hints in the debugger or network log. I haven't determined whether it's related to the plugin changes or not... more than likely it's some misconfiguration on my side
I'm going to keep looking into the courseware error for my own edification, but if you feel comfortable with merging right now, that's OK with me.
regisb
force-pushed
the
regisb/plugin-v1
branch
from
f4b468d to
4ee15e9
Compare
We upgrade this plugin to make use of the v1 plugin API. As a consequence, we are able to condition image pull/push based on whether users have modified the Docker image tag. Inspiration from this neat trick: https://discuss.overhang.io/t/why-is-the-mfe-image-not-pre-built/2260/6 See: openedx-unsupported/wg-developer-experience#59
regisb
force-pushed
the
regisb/plugin-v1
branch
from
4ee15e9 to
024eca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We upgrade this plugin to make use of the v1 plugin API. As a consequence, we
are able to condition image pull/push based on whether users have modified the
Docker image tag.
Inspiration from this neat trick: https://discuss.overhang.io/t/why-is-the-mfe-image-not-pre-built/2260/6
See: openedx-unsupported/wg-developer-experience#59