This repository has been archived by the owner on May 2, 2024. It is now read-only.
Rewrite the tutor-mfe plugin to use the V1 API #59
Assignees
Labels
bug
Report of or fix for something that isn't working as intended
Comments
kdmccormick
added
bug
regisb
added a commit
to overhangio/tutor-mfe
that referenced
this issue
Apr 15, 2022
We upgrade this plugin to make use of the v1 plugin API. As a consequence, we are able to condition image pull/push based on whether users have modified the Docker image tag. Inspiration from this neat trick: https://discuss.overhang.io/t/why-is-the-mfe-image-not-pre-built/2260/6 See: openedx-unsupported/wg-developer-experience#59
|
Here's the PR: overhangio/tutor-mfe#44 |
regisb
added a commit
to overhangio/tutor-mfe
that referenced
this issue
Apr 15, 2022
We upgrade this plugin to make use of the v1 plugin API. As a consequence, we are able to condition image pull/push based on whether users have modified the Docker image tag. Inspiration from this neat trick: https://discuss.overhang.io/t/why-is-the-mfe-image-not-pre-built/2260/6 See: openedx-unsupported/wg-developer-experience#59
kdmccormick
moved this from In Progress
to In Review
in Tutor DevEnv Adoption (OLD BOARD)
regisb
added a commit
to overhangio/tutor-mfe
that referenced
this issue
Apr 19, 2022
We upgrade this plugin to make use of the v1 plugin API. As a consequence, we are able to condition image pull/push based on whether users have modified the Docker image tag. Inspiration from this neat trick: https://discuss.overhang.io/t/why-is-the-mfe-image-not-pre-built/2260/6 See: openedx-unsupported/wg-developer-experience#59
regisb
added a commit
to overhangio/tutor-mfe
that referenced
this issue
Apr 19, 2022
We upgrade this plugin to make use of the v1 plugin API. As a consequence, we are able to condition image pull/push based on whether users have modified the Docker image tag. Inspiration from this neat trick: https://discuss.overhang.io/t/why-is-the-mfe-image-not-pre-built/2260/6 See: openedx-unsupported/wg-developer-experience#59
regisb
added a commit
to overhangio/tutor-mfe
that referenced
this issue
Apr 19, 2022
We upgrade this plugin to make use of the v1 plugin API. As a consequence, we are able to condition image pull/push based on whether users have modified the Docker image tag. Inspiration from this neat trick: https://discuss.overhang.io/t/why-is-the-mfe-image-not-pre-built/2260/6 See: openedx-unsupported/wg-developer-experience#59
|
was closed last week by overhangio/tutor-mfe#44 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Context
Once #32 is finished, we'll eventually need to rewrite the official plugins. It'll be good to have at least one plugin rewritten in time for the Lisbon conference. Let's try to do tutor-mfe, as there is a specific bugfix we could make to it once it's using the V1 API: https://discuss.overhang.io/t/why-is-the-mfe-image-not-pre-built/2260/6?u=kdmccormick
Acceptance
Do it.
Integrate this hack into the rewrite: https://discuss.overhang.io/t/why-is-the-mfe-image-not-pre-built/2260/6?u=kdmccormick
The text was updated successfully, but these errors were encountered: