Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the version installed after installing #3749

Closed

Conversation

MohammedWaheeb
Copy link

@MohammedWaheeb MohammedWaheeb commented Jul 22, 2023

This was requested by a user on twitter

Closes #3720

@Electroid
Copy link
Contributor

Instead of making a request to the Github API, it can just output the result of bun -v

@MohammedWaheeb
Copy link
Author

@Electroid done

@paperclover
Copy link
Member

Closes #3720

(i know typing this in the main comment will make it close but idk if i type it in a comment here)

@MohammedWaheeb
Copy link
Author

@paperdave is there anything i need to do so it can be merged

@birkskyum
Copy link
Collaborator

birkskyum commented Aug 11, 2023

can we make a way to print the commit hash a version is build from?

When I use bun -v i just see the generic:

➜ bun -v
0.7.4

An example of a more informative cli is rustc:

rustc -V
rustc 1.70.0 (90c541806 2023-05-31) (built from a source tarball)

@paperclover
Copy link
Member

can we make a way to print the commit hash a version is build from?

When I use bun -v i just see the generic:

➜ bun -v
0.7.4

An example of a more informative cli is rustc:

rustc -V
rustc 1.70.0 (90c541806 2023-05-31) (built from a source tarball)

#4027 added bun --revision which prints a string like

0.7.4-debug+d6cf039ccd0e3fd36f57564c816e68fef1403189

(we cannot change -v because bun upgrade relies on it and would break older bun upgrades)

@MohammedWaheeb
Copy link
Author

@paperdave should i add it next to or under the version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bun version into CLI output of the install script
5 participants