Make github compare link in bun upgrade --canary use the git sha of the new build instead of main

[leeoniya]

What platform is your computer?

Linux 6.1.4-arch1-1 x86_64 unknown

How did you attempt to install or upgrade?

What do you see instead?

one hash is from 30min ago, the other is from 3 days ago. they can't both be correct?

Additional information

No response

[Jarred-Sumner]

The previous hash is the one you were on before. The 2nd hash is the one you're on now.

[leeoniya]

but it won't always be main then since it needs to wait for CI? so main should actually be the revision hash?

can the compare url use shortened hashes, too?

[Jarred-Sumner]

Yeah, it’s hardcoded to main because we didn’t have —revision when this code was last updated

…

On Thu, Aug 10, 2023 at 7:46 PM Leon Sorokin ***@***.***> wrote: but it won't always be main then since it needs to wait for CI? so main should actually be the revision hash? — Reply to this email directly, view it on GitHub <#4115 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFNGSZVUZOCC77GTGDS2ATXUWMIZANCNFSM6AAAAAA3MKI7EU> . You are receiving this because you commented.Message ID: ***@***.***>

[birkskyum]

Related to

• Display the version installed after installing #3749