Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(which/windows): ignore file extension case #10102

Merged
merged 10 commits into from
Apr 15, 2024
Merged

fix(which/windows): ignore file extension case #10102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
85bdb25
fix(which/windows): ignore file extension case
SunsetTechuila Apr 8, 2024
25fcb1a
Merge branch 'main' into main
SunsetTechuila Apr 9, 2024
fb3ad51
feat(which): add test for `endsWithExtension` fun
SunsetTechuila Apr 9, 2024
e523b1f
Merge branch 'main' into main
SunsetTechuila Apr 10, 2024
1056b26
Merge branch 'main' into main
SunsetTechuila Apr 11, 2024
2b0735f
Merge branch 'main' into main
SunsetTechuila Apr 11, 2024
e555c66
Revert "feat(which): add test for `endsWithExtension` fun"
SunsetTechuila Apr 11, 2024
cecb63a
add test
SunsetTechuila Apr 11, 2024
52056fa
Merge branch 'main' into main
SunsetTechuila Apr 12, 2024
ab6221e
Merge branch 'main' into main
gvilums Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/which.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ pub fn endsWithExtension(str: []const u8) bool {
const file_ext = str[str.len - 3 ..];
inline for (win_extensions) |ext| {
comptime bun.assert(ext.len == 3);
if (bun.strings.eqlComptimeCheckLenWithType(u8, file_ext, ext, false)) return true;
if (bun.strings.eqlCaseInsensitiveASCIIICheckLength(file_ext, ext)) return true;
}
return false;
}
Expand Down
1 change: 1 addition & 0 deletions test/js/bun/util/which.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ if (isWindows) {
test("which", () => {
expect(which("cmd")).toBe("C:\\Windows\\system32\\cmd.exe");
expect(which("cmd.exe")).toBe("C:\\Windows\\system32\\cmd.exe");
expect(which("cmd.EXE")).toBe("C:\\Windows\\system32\\cmd.EXE");
expect(which("cmd.bat")).toBe(null);
const exe = basename(process.execPath);
const dir = join(process.execPath, "../");
Expand Down
Loading