-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(which/windows): ignore file extension case #10102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add a unit test to verify this works?
Ok, I will |
@paperdave done |
We don't currently run zig tests in our test suite. Instead, I suggest adding something like the following to test.if(isWindows)("which is case-insensitive", () => {
expect(which("cmd.EXE")).toBe("C:\\Windows\\system32\\cmd.exe");
}) (feel free to adjust) |
oh, so you have os-specific js/ts tests, i see now |
This reverts commit fb3ad51.
@gvilums done |
Thank you |
What does this PR do?
This fixes #10101
How did you verify your code works?
I compiled the executable and tested it manually