Metatables for Lua #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added so it's possible to use metatables for objects instead of using numeric values to get data. Added "onModalWindow" creatureevent to handle the "ModalWindow" metatable. Added a "Position" metatable to it's possible to add or subtract positions.
|
Perfect mean 👍 |
|
👍 |
|
Using index 0 in lua_touserdata and other functions that fetch data from the Lua stack is never acceptable (see: http://www.lua.org/manual/5.1/manual.html#3.2), although both Lua and LuaJIT return the last popped value we shouldn't rely on undefined behavior which is said to be unacceptable. I'm merging this pull request because it builds and hopefully doesn't break anything, but will follow up with Lua stack fix commits. |
Closed
Closed
Closed
mokerhamer
referenced
this pull request
May 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added so it's possible to use metatables for objects instead of using
numeric values to get data.
Added "onModalWindow" creatureevent to handle the "ModalWindow"
metatable.
Added a "Position" metatable to it's possible to add or subtract
positions.