Skip to content

Commit

Permalink
Fix bug with network packet splitting
Browse files Browse the repository at this point in the history 
Fixes #1403
  • Loading branch information
@marksamman
marksamman committed May 8, 2016
1 parent 0d59454 commit 2dfcb49
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions src/protocol.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,13 @@ void Protocol::onRecvMessage(NetworkMessage& msg)
OutputMessage_ptr Protocol::getOutputBuffer(int32_t size)
{
//dispatcher thread
if (outputBuffer && NetworkMessage::MAX_PROTOCOL_BODY_LENGTH >= outputBuffer->getLength() + size) {
return outputBuffer;
} else {
if (!outputBuffer) {
outputBuffer = OutputMessagePool::getOutputMessage();
} else if ((outputBuffer->getLength() + size) > NetworkMessage::MAX_PROTOCOL_BODY_LENGTH) {
send(outputBuffer);
outputBuffer = OutputMessagePool::getOutputMessage();
return outputBuffer;
}
return outputBuffer;
}

void Protocol::XTEA_encrypt(OutputMessage& msg) const
Expand Down

17 comments on commit 2dfcb49

@mokerhamer
Copy link

@mokerhamer mokerhamer commented on 2dfcb49 May 9, 2016 •
edited by DSpeichert
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this fix the error logs displayed below?

Crash 1;
l::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>&, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)>&) ()
No symbol table info available.
#38 0x000000000084e57e in void boost::asio::detail::asio_handler_invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, uns---Type <return> to continue, or q <return> to quit---

igned long>, boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>&, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >*) ()
No symbol table info available.
#39 0x000000000084e127 in void boost_asio_handler_invoke_helpers::invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, bo---Type <return> to continue, or q <return> to quit---

ost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> > >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>&, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >&) ()
No symbol table info available.
#40 0x000000000084d92f in boost::asio::detail::reactive_socket_recv_op<boost::asio::mutable_buffers_1, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> > >::do_complete(boost::asio::detail::task_io_service_, boost::asio::detail::task_io_service_operation_, boost::system::error_code const&, unsigned long) ()

No symbol table info available.
---Type <return> to continue, or q <return> to quit---
#41 0x0000000000a7595a in boost::asio::detail::task_io_service_operation::complete(boost::asio::detail::task_io_service&, boost::system::error_code const&, unsigned long) ()

No symbol table info available.
#42 0x0000000000a769b1 in boost::asio::detail::task_io_service::do_run_one(boost::asio::detail::scoped_lockboost::asio::detail::posix_mutex&, boost::asio::detail::task_io_service_thread_info&, boost::system::error_code const&) ()

No symbol table info available.
#43 0x0000000000a766f1 in boost::asio::detail::task_io_service::run(boost::system::error_code&) ()

No symbol table info available.
#44 0x0000000000a76c1d in boost::asio::io_service::run() ()

No symbol table info available.
#45 0x0000000000a740a9 in ServiceManager::run() ()

No symbol table info available.
#46 0x00000000009c651f in main ()

No symbol table info available.

Crash 2;
#6  0x000000000098117d in std::_Rb_tree<int, std::pair<int const, std::string>, std::_Select1st<std::pair<int const, std::string> >, std::less<int>, std::allocator<std::pair<int const, std::string> > >::_S_key(std::_Rb_tree_node<std::pair<int const, std::string> > const*) ()

No symbol table info available.
Backtrace stopped: previous frame inner to this frame (corrupt stack?)

Crash 3;
#26 0x000000000084e9c2 in void boost_asio_handler_invoke_helpers::invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>&, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)>&) ()

No symbol table info available.
---Type <return> to continue, or q <return> to quit---
#27 0x000000000084e57e in void boost::asio::detail::asio_handler_invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>, boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>&, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >*) ()

No symbol table info available.
#28 0x000000000084e127 in void boost_asio_handler_invoke_helpers::invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> > >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>&, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >&) ()

No symbol table info available.
#29 0x000000000084d92f in boost::asio::detail::reactive_socket_recv_op<boost::asio::mutable_buffers_1, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> > >::do_complete(boost::asio::detail::task_io_service_, boost::asio::detail::task_io_service_operation_, boost::system::error_code const&, unsigned long) ()

No symbol table info available.
#30 0x0000000000a7595a in boost::asio::detail::task_io_service_operation::complete(boost::asio::detail::task_io_service&, boost::system::error_code const&, unsigned long) ()

No symbol table info available.
#31 0x0000000000a769b1 in boost::asio::detail::task_io_service::do_run_one(boost::asio::detail::scoped_lockboost::asio::detail::posix_mutex&, boost::asio::detail::task_io_service_thread_info&, boost::system::error_code const&) ()

No symbol table info available.
#32 0x0000000000a766f1 in boost::asio::detail::task_io_service::run(boost::system::error_code&) ()

No symbol table info available.
#33 0x0000000000a76c1d in boost::asio::io_service::run() ()

No symbol table info available.
#34 0x0000000000a740a9 in ServiceManager::run() ()

No symbol table info available.
#35 0x00000000009c651f in main ()

No symbol table info available.

No symbol table info available.
#13 0x000000000083b650 in Connection::parsePacket(boost::system::error_code const&) ()

No symbol table info available.
#14 0x000000000084d0f2 in void std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)>::_M_callstd::shared_ptr<Connection&, boost::system::error_code const&>(std::shared_ptr<Connection>&, void const volatile*, boost::system::error_code const&) const ()

No symbol table info available.
#15 0x000000000084c266 in void std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)>::operator()std::shared_ptr<Connection&, boost::system::error_code const&, void>(std::shared_ptr<Connection>&, boost::system::error_code const&) const ()

No symbol table info available.
#16 0x000000000084af71 in void std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)>::__call<void, boost::system::error_code const&, unsigned long const&, 0ul, 1ul>(std::tuple<boost::system::error_code const&, unsigned long const&>&&, std::_Index_tuple<0ul, 1ul>) ()

No symbol table info available.
#17 0x000000000084943c in void std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)>::operator()<boost::system::error_code const&, unsigned long const&, void>(boost::system::error_code const&, unsigned long const&)

()


No symbol table info available.
---Type <return> to continue, or q <return> to quit---
#18 0x0000000000846d59 in boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >::operator()(boost::system::error_code const&, unsigned long, int) ()

No symbol table info available.
#19 0x000000000084ec46 in boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>::operator()() ()

No symbol table info available.
#20 0x000000000084eaf0 in void boost::asio::asio_handler_invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long> >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>&, ...) ()

No symbol table info available.
#21 0x000000000084e972 in void boost_asio_handler_invoke_helpers::invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>&, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)>&) ()

No symbol table info available.
#22 0x000000000084e52e in void boost::asio::detail::asio_handler_invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>, boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>&, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >*) ()

No symbol table info available.
#23 0x000000000084e0d7 in void boost_asio_handler_invoke_helpers::invoke<boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> > >(boost::asio::detail::binder2<boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >, boost::system::error_code, unsigned long>&, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> >&) ()

No symbol table info available.
#24 0x000000000084d8df in boost::asio::detail::reactive_socket_recv_op<boost::asio::mutable_buffers_1, boost::asio::detail::read_op<boost::asio::basic_stream_socket<boost::asio::ip::tcp, boost::asio::stream_socket_service<boost::asio::ip::tcp> >, boost::asio::mutable_buffers_1, boost::asio::detail::transfer_all_t, std::_Bind<std::_Mem_fn<void (Connection::*)(boost::system::error_code const&)> (std::shared_ptr<Connection>, std::_Placeholder<1>)> > >::do_complete(boost::asio::detail::task_io_service_, boost::asio::detail::task_io_service_operation_, boost::system::error_code const&, unsigned long) ()

---Type <return> to continue, or q <return> to quit---
No symbol table info available.
#25 0x0000000000a75574 in boost::asio::detail::task_io_service_operation::complete(boost::asio::detail::task_io_service&, boost::system::error_code const&, unsigned long) ()

No symbol table info available.
#26 0x0000000000a765cb in boost::asio::detail::task_io_service::do_run_one(boost::asio::detail::scoped_lockboost::asio::detail::posix_mutex&, boost::asio::detail::task_io_service_thread_info&, boost::system::error_code const&) ()

No symbol table info available.
#27 0x0000000000a7630b in boost::asio::detail::task_io_service::run(boost::system::error_code&) ()

No symbol table info available.
#28 0x0000000000a76837 in boost::asio::io_service::run() ()

No symbol table info available.
#29 0x0000000000a73cc3 in ServiceManager::run() ()

No symbol table info available.
#30 0x00000000009c6139 in main ()

No symbol table info available.

@marksamman
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. You have probably made modifications to your source code which are causing these crashes.

@mokerhamer
Copy link

@mokerhamer mokerhamer commented on 2dfcb49 May 9, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reply, i'm having alot of difficulties finding the cause of the crashes i hoped this would solve it.

Can u see what is causing the crash (i cant find valuable information in the crash logs)? just to push me in the right direction? The server randomly crashes with 1 player hunting cyclops's.

@marksamman
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right place to discuss that, and besides, I have no interest in helping people who turn their back on the community when the knowledge is in their hands. What you, and other community members, did in a previous flash client discussion thread on OTLand is a disgrace.

@mokerhamer
Copy link

@mokerhamer mokerhamer commented on 2dfcb49 May 9, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you're not up-to-date with the facts. I've been threatened and harassed. But your answer is clear. Besides that please take a look at what I've contributed in the past.

AND besides that, this is for ORTS update. I've already let ORTS members know that i'm going to release all map parts, monsters, quests, npcs, and alot of bug fixes, Premium shop, Unjustified counter, etc. Znote and Gesior are working to build flash client into their website.

Please reconsider your opinion about me, i've done nothing wrong to receive the "disgrace".

@marksamman
Copy link
Member Author

@marksamman marksamman commented on 2dfcb49 May 9, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will reconsider my opinion of you when what you are saying can be publicly verifiable. I am well aware of your past contributions which date back to long before TFS 1.0 was released, but haven't seen any meaningful contribution from you since then.

Here's a quote of what you said in that thread: "To be honest, i only wish to share Flash client with people who contribute. I'll be maiking a privet Github project soon.". So I don't think the word "disgrace" was undeserved, but here's more if you need help remembering: https://otland.net/threads/using-flash-client-in-ots.230791/page-2#post-2228533

The kind of behavior that you, WibbenZ and other people in that thread are practicing does not belong in an open source community. It is a disgrace. It is elitism, it does not move OpenTibia forward. In fact, it moves us backwards by discouraging other people from contributing because they know certain people refuse to share their findings with the community. If you want to discuss this further, you may start a thread about it on OTLand, because it may be generating noise for people who are watching this repository.

@mokerhamer
Copy link

@mokerhamer mokerhamer commented on 2dfcb49 May 9, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, if you don't mind i will post this message towards those people and those who threatened me. And yes, i really wish to release everything. I'm just scared of the minor bugs, those will make people hunt me down for support. That's why i'm trying to resolve the issue above.

Going to create a thread soon~ Let me fix a couple of bugs (like the random crash bug above :() so i can try to make a release.

Proof of contributing (see date!) to ORTS, I've been working on the update for a couple of months now.
http://puu.sh/oLuyA/7216efdc9b.png

@WibbenZ
Copy link
Member

@WibbenZ WibbenZ commented on 2dfcb49 May 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi me and milice had the same ide, we would get spammed abt bugs and ppl wanting help.

And mark I can throw the same rock back, why are you not making ex the unjust window public or other things you did with shadowcores?

@HeavenIsLost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marksamman about this commit, it should be added to this wikipage?
https://github.com/otland/forgottenserver/wiki/Changelog-1.2

@marksamman
Copy link
Member Author

@marksamman marksamman commented on 2dfcb49 May 10, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenDol
Copy link

@BenDol BenDol commented on 2dfcb49 May 10, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how @WibbenZ doesn't get a reply about all these features that weren't released here haha

@WibbenZ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenDol Im hardely active in ots anymore, mainly to reasons like this.
I also "love" how Mark thinks that we should release everything we have to be welcome here, as he who still has done alot for this repo keeps his files to himself.

You can see here below, that unless we give everything out that we make are the ones who are the problem.
But then again, if he already has the files / fixes w/e why not release them?

It's such a double moral.
If is he allowed to keep his files we should also, so why not just stop this long lost discussion and agree that we release what we wanna release.

Idc if mark releases his files, its up to him as it should be.
But don't go saying everyone else should when you don't.

The kind of behavior that you, WibbenZ and other people in that thread are practicing does not belong in an open source community. It is a disgrace. It is elitism, it does not move OpenTibia forward. In fact, it moves us backwards by discouraging other people from contributing because they know certain people refuse to share their findings with the community.

@HeavenIsLost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marksamman I'm the one that report #1403 and i was using tfs 1.1 with old networking code. So its something that was already "broken" in tfs 1.1 and probably 1.0.

@marksamman
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case #1403 might not be fixed. Can you check if it is?

@HeavenIsLost
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On tfs 1.1 the whole networking stack is different from 1.2, so i had to copy your fix into 1.1 code like this:
http://pastebin.com/tP3FdwK5
the problem is, Connection::send(OutputMessage_ptr msg) got a different code and a FIXME in tfs 1.1 that has been fixed in 1.2:
http://pastebin.com/CXfPJG0M

@marksamman
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should test it on 1.2, not by trying to backport the fix, because it's not compatible with TFS 1.1 network stack unless you replace the entire network code.

@HeavenIsLost
Copy link
Contributor

@HeavenIsLost HeavenIsLost commented on 2dfcb49 May 10, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested with both 1.1 and 1.2. With 1.1 i have tested two times and there was a client debug with the same house and amount of items. 1.2 got no debug with the same amount of items and same house as tfs 1.1 test, i have tested 3 times.

Please sign in to comment.