Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect version display of pg_bulkload #142

Merged
merged 11 commits into from
Feb 8, 2023

Conversation

zwyan0
Copy link
Contributor

@zwyan0 zwyan0 commented Feb 2, 2023

No description provided.

lib/Makefile Outdated Show resolved Hide resolved
SPECS/pg_bulkload-pg10.spec Outdated Show resolved Hide resolved
lib/Makefile Outdated Show resolved Hide resolved
Changed the method of generating pg_bulkload.sql and
getting the version number of pg_bulkload.
Removed generation methods for pg_bulkload.sql and
uninstall_pg_bulkload.sql.
Manual has also been modified.
lib/Makefile Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
pg_bulkload does not support upgrades using ALTER EXTENSION,
uninstall_pg_bulkload.sql is also not required.
And I added the description how to upgrade pg_bulkload.
mikecaat and others added 3 commits February 7, 2023 12:06
pg_bulkload expects that the user is a superuser.

```
# "test" is not a superuser
$ pg_bulkload sample_csv.ctl --username test --dbname test
NOTICE: BULK LOAD START
ERROR: query failed: ERROR:  must be superuser to use pg_bulkload
DETAIL: query was: SELECT * FROM pgbulkload.pg_bulkload($1)
```

Co-authored-by: Masahiro Ikeda <masahiro.ikeda.us@hco.ntt.co.jp>
 - Removed unnecessary lines from the Makefile and SPECS files.
 - Removed PostgreSQL 9.6 SPEC file.
 - Corrected a typo in the manual.
Copy link
Contributor

@mikecaat mikecaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks good to me.

@zwyan0 zwyan0 merged commit c5b508e into ossc-db:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants