Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension version pg_bulkload mistake #141

Closed
cesarjorgemartinez opened this issue Feb 1, 2023 · 6 comments
Closed

Extension version pg_bulkload mistake #141

cesarjorgemartinez opened this issue Feb 1, 2023 · 6 comments

Comments

@cesarjorgemartinez
Copy link

cesarjorgemartinez commented Feb 1, 2023

I compile the pg_bulkload using (version 3.1.20 https://github.com/ossc-db/pg_bulkload/releases/download/VERSION3_1_20/pg_bulkload-3.1.20.tar.gz):
USE_PGXS=1 make
USE_PGXS=1 make install

And when I install the extension:
create extension pg_bulkload;

Always show the version 1.0. Then I don't known if exists any fails or I missing any steps.

@mikecaat
Copy link
Contributor

mikecaat commented Feb 2, 2023

You mean the following results, don't you? It seems a little strange.

$ pg_bulkload --version 
pg_bulkload 3.1.20

psql=# \dx
                                     List of installed extensions
    Name     | Version |   Schema   |                           Description
-------------+---------+------------+-----------------------------------------------------------------
 pg_bulkload | 1.0     | public     | pg_bulkload is a high speed data loading utility for PostgreSQL
 plpgsql     | 1.0     | pg_catalog | PL/pgSQL procedural language
(2 rows)

@mikecaat
Copy link
Contributor

mikecaat commented Feb 2, 2023

PR: #142

@cesarjorgemartinez
Copy link
Author

cesarjorgemartinez commented Feb 2, 2023

I see the PR but, I have a doubt, you would be force for each version to change manually this.

zwyan0 added a commit to zwyan0/pg_bulkload that referenced this issue Feb 6, 2023
Changed the method of generating pg_bulkload.sql and
getting the version number of pg_bulkload.
@zwyan0
Copy link
Contributor

zwyan0 commented Feb 6, 2023

I see the PR but, I have a doubt, you would be force for each version to change manually this.

Hi @cesarjorgemartinez ,thank you for your coment.
As you said, the previous code did have to manually modify the version each time, which is stupid.
So I made a modification.

@cesarjorgemartinez
Copy link
Author

Great!
Then LGTM

@zwyan0
Copy link
Contributor

zwyan0 commented Feb 8, 2023

Great! Then LGTM

Thank you for your confirmation.

zwyan0 added a commit that referenced this issue Feb 8, 2023
* Fixed incorrect version display of pg_bulkload

Previously, pg_bulkload always showed the wrong version 
after registering to the DB. It will confuses users.
So, changed the method of generating pg_bulkload--${version}.sql and
getting the version number of pg_bulkload.
Reported-by : cesarjorgemartinez

* Removed unnecessary file

pg_bulkload does not support upgrades using ALTER EXTENSION,
and since PostgreSQL 9.2, pg_bulkload is registered to DB using 
CREATE EXTENSION. So. we removed the manual registration method.

* Added the description how to upgrade pg_bulkload.

* Removed unnecessary lines from the Makefile and SPECS file

Removed PostgreSQL 9.6 SPEC file.

---------

Co-authored-by: mikecaat <35882227+mikecaat@users.noreply.github.com>
Co-authored-by: Masahiro Ikeda <masahiro.ikeda.us@hco.ntt.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants