ScanCode error handling improvements #9197
Merged
Commits on Sep 26, 2024
-
docs(scancode): Move a comment to a more relevant location
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
-
feat(scancode): Try to to get more information on failures
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
-
chore(scanner): Get the time for a failure summary only once
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
-
fix(scanner): Properly handle
scanPath()exceptionsThere have reportedly [1] been cases where ScanCode apparently crashed without printing anything to `stderr`, resulting in no `result.json` file being written, which causes `readText()` to throw a `FileNotFoundException`. Properly handle such cases by logging and creating an issue for them. [1]: https://oss-review-toolkit.slack.com/archives/C9NNJ54B1/p1727277816661189?thread_ts=1724222709.453049 Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.