ScanCode error handling improvements #9197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9197 +/- ##
=========================================
Coverage 67.10% 67.10%
Complexity 1187 1187
=========================================
Files 240 240
Lines 7908 7908
Branches 914 914
=========================================
Hits 5307 5307
Misses 2233 2233
Partials 368 368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
previously requested changes
Sep 25, 2024
| ) | ||
| } | ||
| val summary = runCatching { | ||
| scanner.scanPath(downloadDir, filteredContext) |
There was a problem hiding this comment.
commit-message: Could you describe, why catching scanPath() throws is now necessary and maybe outline a real world case where it throws?
There was a problem hiding this comment.
why catching scanPath() throws is now necessary
It's not now necessary, but always was for proper handling of errors. I've clarified this in the commit message.
sschuberth
force-pushed
the
scancode-imps
branch
from
30d01f0
to
82096a1
Compare
sschuberth
force-pushed
the
scancode-imps
branch
from
82096a1
to
682fd2b
Compare
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
There have reportedly [1] been cases where ScanCode apparently crashed without printing anything to `stderr`, resulting in no `result.json` file being written, which causes `readText()` to throw a `FileNotFoundException`. Properly handle such cases by logging and creating an issue for them. [1]: https://oss-review-toolkit.slack.com/archives/C9NNJ54B1/p1727277816661189?thread_ts=1724222709.453049 Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
force-pushed
the
scancode-imps
branch
from
682fd2b
to
ec04ed0
Compare
nnobelis
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.