-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add VCS curations for org.niis.xrd4j
packages
#165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
xrd4j-curations
branch
2 times, most recently
from
January 30, 2024 16:59
bb1b148
to
e334ef8
Compare
This is required to support e.g. the use-case described at [1]. The `toCurationPath()` function already supports empty package names and uses `_.yml` as a file name in that case. [1]: oss-review-toolkit/ort#5105 (comment) Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
force-pushed
the
xrd4j-curations
branch
from
January 30, 2024 17:09
e334ef8
to
293d316
Compare
FYI @petkivim, this is required unless there is a release with nordic-institute/xrd4j#30 included, and all users of XRd4J upgrade to that new release. |
@sschuberth The next XRd4J release will include nordic-institute/xrd4j#30, but it will take time until all the users will upgrade to it. Therefore, it's good to have this fix in place. Thanks! |
mnonnenmacher
approved these changes
Jan 31, 2024
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Jan 31, 2024
This is required to support curations like the one added in [1]. [1]: oss-review-toolkit/ort-config#165 Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Feb 1, 2024
This is required to support curations like the one added in [1]. [1]: oss-review-toolkit/ort-config#165 Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Feb 1, 2024
This is required to support curations like the one added in [1]. [1]: oss-review-toolkit/ort-config#165 Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
added a commit
to oss-review-toolkit/ort
that referenced
this pull request
Feb 1, 2024
This is required to support curations like the one added in [1]. [1]: oss-review-toolkit/ort-config#165 Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.