Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add VCS curations for org.niis.xrd4j packages #165

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

sschuberth
Copy link
Member

@sschuberth sschuberth commented Jan 30, 2024

No description provided.

@sschuberth sschuberth requested a review from a team as a code owner January 30, 2024 16:52
@sschuberth sschuberth force-pushed the xrd4j-curations branch 2 times, most recently from bb1b148 to e334ef8 Compare January 30, 2024 16:59
This is required to support e.g. the use-case described at [1]. The
`toCurationPath()` function already supports empty package names and
uses `_.yml` as a file name in that case.

[1]: oss-review-toolkit/ort#5105 (comment)

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth requested a review from a team as a code owner January 30, 2024 17:09
@sschuberth
Copy link
Member Author

FYI @petkivim, this is required unless there is a release with nordic-institute/xrd4j#30 included, and all users of XRd4J upgrade to that new release.

@petkivim
Copy link

@sschuberth The next XRd4J release will include nordic-institute/xrd4j#30, but it will take time until all the users will upgrade to it. Therefore, it's good to have this fix in place. Thanks!

@sschuberth sschuberth merged commit 66d2400 into main Jan 31, 2024
2 checks passed
@sschuberth sschuberth deleted the xrd4j-curations branch January 31, 2024 18:33
sschuberth added a commit to oss-review-toolkit/ort that referenced this pull request Jan 31, 2024
This is required to support curations like the one added in [1].

[1]: oss-review-toolkit/ort-config#165

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth added a commit to oss-review-toolkit/ort that referenced this pull request Feb 1, 2024
This is required to support curations like the one added in [1].

[1]: oss-review-toolkit/ort-config#165

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth added a commit to oss-review-toolkit/ort that referenced this pull request Feb 1, 2024
This is required to support curations like the one added in [1].

[1]: oss-review-toolkit/ort-config#165

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth added a commit to oss-review-toolkit/ort that referenced this pull request Feb 1, 2024
This is required to support curations like the one added in [1].

[1]: oss-review-toolkit/ort-config#165

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants