build(Maven): Fix SCM metadata in the parent POM #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `connection` is only supposed to require read-access and ideally can be used anonymously, so use HTTPS instead SSH as a Git transport. The `url` should point to "A publicly browsable repository", not a Git clone URL, so fix this as well. See [1] for context. [1]: https://maven.apache.org/pom.html#SCM Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
|
FYI @petkivim. |
petkivim
approved these changes
Jan 30, 2024
|
Looks good to me. Thank you for the contribution @sschuberth! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
connectionis only supposed to require read-access and ideally can be used anonymously, so use HTTPS instead SSH as a Git transport. Theurlshould point to "A publicly browsable repository", not a Git clone URL, so fix this as well. See 1 for context.