Modify Naming Conventions for CSV Output File and Excel Output File #558
Conversation
GoFroggyRun
changed the title
GoFroggyRun
changed the title
|
@GoFroggyRun, is this ready for review? |
|
Yes. All I have are included in this PR.
On Jun 13, 2017, at 5:11 PM, Matt Jensen <notifications@github.com<mailto:notifications@github.com>> wrote:
@GoFroggyRun<https://github.com/gofroggyrun>, is this ready for review?
cc @brittainhard<https://github.com/brittainhard>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#558 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AMtSgx8lp7EVn1bo1_B-OO6VG-30QAhIks5sDvsFgaJpZM4NyHK4>.
|
| @@ -8,7 +8,6 @@ static3==0.5.1 | |||
| wsgiref==0.1.2 | |||
| -e git+https://github.com/funkybob/django-flatblocks.git#egg=django-flatblocks | |||
| sendgrid-django | |||
| psycopg2==2.5.4 | |||
There was a problem hiding this comment.
Whats the reasoning behind removing this dependency?
There was a problem hiding this comment.
@brittainhard:
When I was trying to set up everything locally with @PeterDSteinberg, some dependency error message regarding psycopg2 pops out. Removing this dependency seems to resolve such issue.
There was a problem hiding this comment.
What's the dependency issue? Can you get a traceback?
There was a problem hiding this comment.
I'm mainly concerned that this will cause issues on the heroku deployment, since it uses postgres as a database.
There was a problem hiding this comment.
@brittainhard:
I wasn't able to locate the traceback since it was a while ago. Currently my conda list shows that psycopg2 is on 2.7.1. Would this be a problem for heroku deployment?
There was a problem hiding this comment.
In other words, would it be a problem if I change the line
-psycopg2==2.5.4
to
-psycopg2
that removes the version requirement?
There was a problem hiding this comment.
How about this:
psycopg2>=2.5.4
Won't that satisfy everybody?
There was a problem hiding this comment.
@GoFroggyRun if the main issue that you are having issues using postgres locally? If thats the case, there is the option of using SQLite for local development. It's what i use, since I have to alter the database frequently.
Is the problem that your psycopg2 version is causing problems, so you had to upgrade it? In that case @martinholmer that's a reasonable fix.
|
Yes, it very likely will. There must be something to setup the Python
environment to talk to Postgres.
…On Thu, Jun 15, 2017 at 8:15 AM Brittain Hard ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In requirements.txt
<#558 (comment)>
:
> @@ -8,7 +8,6 @@ static3==0.5.1
wsgiref==0.1.2
-e git+https://github.com/funkybob/django-flatblocks.git#egg=django-flatblocks
sendgrid-django
-psycopg2==2.5.4
I'm mainly concerned that this will cause issues on the heroku deployment,
since it uses postgres as a database.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#558 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABzcWm_9f4hwr2HS84iJX4KrNUNJ9f_Mks5sET7BgaJpZM4NyHK4>
.
|
|
Thanks @martinholmer and @brittainhard for your advices. It's the version of |
|
Looks good to me. +1 |
This PR tries to partially resolve concerns addressed in #534.
In particular, @MattHJensen suggested naming scheme for csv output files and excel output files in 534 comment. This PR mostly follows such scheme, expect substituting suggested keywords "payroll-income" and 'income" with "combined" and "individual" respectively so that the file name corresponds to the title of the table.
Based on local tests, the output file names read:
Note that 127 is my run number, which will be changing according to the url. Please also note that the some buttons are not working for total liabilities tables, and currently the only output file for that table is in the format
xxx_liabilities_change.@MattHJensen Could you review? Any comments, concerns or remarks are welcomed.