Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaxBrain "Build Table" enhancements #534

Closed
martinholmer opened this issue Apr 13, 2017 · 7 comments
Closed

TaxBrain "Build Table" enhancements #534

martinholmer opened this issue Apr 13, 2017 · 7 comments
Assignees
Milestone

Comments

@martinholmer
Copy link
Contributor

The "Build Table" feature at the bottom of the TaxBrain static results page is very nice. I've used it off and on over the past year mostly by building a table and viewing it and maybe making a note of a few numbers that I'm viewing.

I've just started exploring the other options of what to do with a built table: Print, Copy and CSV.
I don't have Excel on my computer so I didn't try the fourth option.

Here are a few things I noticed that could be improved to make the user experience better.

(1) When using Print, the table looks good on the page, but a second blank page gets printed out even though there is plenty of whitespace at the bottom of the first page. It's sort of a hassle to have to remember to switch the print option from All to Page 1, and even if you know to do that, the one printed page says it is 1/2, which is confusing. Someone might think they were missing some output.

(2) When using Copy, everything works fine except the title of the built table is absent. This is a major shortcoming. The built table's title is included in the Print output, so I don't know why it wouldn't be included in the Copy output.

(3) When using CSV, the downloaded file loads up into my spreadsheet (OpenOffice) just fine except again the critically important title of the built table is missing.

I'm a novice user of these TaxBrain capabilities, so I could have made a mistake. But if not, fixing these things would leave users would a much better impression of TaxBrain.

@MattHJensen @PeterDSteinberg @brittainhard

@martinholmer
Copy link
Contributor Author

martinholmer commented Apr 14, 2017

Another enhancement needs to be added to the list in TaxBrain issue #534.

It has already been pointed out that the title of the built table is not included in the downloaded CSV file or Copy. But there is another problem: the name of the downloaded file is sort of laughable and completely useless. Here is what I got in my ~/Download directory after building four different distributional tables and clicking on the CSV button:

  989 Apr 14 17:09   Welcome to TaxBrain  TaxBrain (1).csv
  976 Apr 14 17:10   Welcome to TaxBrain  TaxBrain (2).csv
  961 Apr 14 17:12   Welcome to TaxBrain  TaxBrain (3).csv
  640 Apr 14 17:07   Welcome to TaxBrain  TaxBrain.csv

First of all, the embedded spaces in the file names sometimes require awkward quoting when working with the files on a local computer. Can we get rid of all the spaces in the downloaded file names?

Second, the file name is the same for every downloaded file. How is a user supposed to know what is in each file? They can't look inside the file because there no table title to tell them what it is. At a minimum the file name should include the TaxBrain run number. Ideally, the file name would give users some idea of what kind of table is in the file.

I'm trying to write up some TaxBrain user documentation, but honestly I don't see how a user could do any serious tax analysis and save it to a local computer without going through a lot of work renaming files and adding the table titles into each downloaded file. I don't think this is the ease-of-use level we are trying to provide users. Over the past month or so, enhancement requests like this have been assigned a low priority. If we don't fix these (what I consider) serious problems soon, we'll end up having TaxBrain user documentation that spends much of its time advising users how to work around these kinds of problems. I don't think that is a situation we want to be in.

@MattHJensen @PeterDSteinberg @brittainhard

@MattHJensen MattHJensen added this to the 3 milestone Apr 18, 2017
@MattHJensen
Copy link
Contributor

Moving to milestone 3. Thanks @martinholmer for opening.

@MattHJensen
Copy link
Contributor

MattHJensen commented Apr 22, 2017

Summary

  • TOTAL LIABILITIES TABLES: should automatically print all 10 years onto the page (to 2026). Now only 9 (to 2025). Either shrink cols, or if possible, have the browser default to printing landscape.
    image

  • TOTAL LIABILITIES CHANGE TABLE: when I click "reform" or "current law" the output options disappear. I should still be able to print etc.
    image

  • BUILD A TABLE TABLES: Print option should not include an extra blank page.
    image

  • ALL TABLES: the Copy, CSV, and Excel options should keep the title of the table in the top row. Currently the title of the table is not included.

  • TOTAL LIABILITIES TABLES: Should not include the year in the table name. Currently the "Change" and "Current Law" tables include the start year in parenthesis.

  • TOTAL LIABILITIES CHANGE TABLE: TOTAL LIABILITIES CHANGE BY CALENDAR YEAR (2017) should be TOTAL LIABILITIES BY CALENDAR YEAR (CHANGE)

  • ALL TABLES: For csv and excel downloads, adopt the file naming convention from TaxBrain "Build Table" enhancements #534 (comment)

  • [From @martinholmer More enhancements needed for TaxBrain results tables #544] The downloaded CSV file has all the numerical values enclosed in quotation marks (like "1,234.5"). This is a problem for users who have uploaded reform/assumption files to TaxBrain and want to download TaxBrain results for analysis on their local computer using command-line tools. Can the commas and enclosing quotation marks be removed from the downloaded CSV file?

  • [From @martinholmer More enhancements needed for TaxBrain results tables #544] For some reason the terminology for the diagnostic tables and the difference tables are different. The difference tables sensibly use "by" (as in "by income decile") while the diagnostic tables use the strange terminology "per" (as in "per income decile"). Can we standardize on "by"?

@MattHJensen
Copy link
Contributor

MattHJensen commented Apr 22, 2017

@martinholmer, thanks for suggesting better filenames.

Here's a possible file naming scheme:

TOTAL LIABILITIES TABLES

Formula
[run#]_liabilities_[change/reform/currentlaw]

Examples
10000_liabilities_change
10000_liabilities_reform
10000_liabilities_currentlaw

BUILD A TABLE TABLES

Formula
[run#]_[year]_[1st selection]_[2nd selection]_[4th selection]

Examples
10000_2017_diagnostic_currentlaw_bins
10000_2017_diagnostic_reform_deciles
10000_2017_difference_payroll_bins
10000_2017_difference_payroll-income_deciles

Very much welcome feedback and other suggestions.

@martinholmer
Copy link
Contributor Author

@MattHJensen, This would be a big improvement. Thanks.
Why don't we go with this (or some refinement of your devising) for now and see how it works.

@MattHJensen
Copy link
Contributor

@GoFroggyRun, could you open a PR that closes this issue? See this overview comment.

@martinholmer
Copy link
Contributor Author

There has been some progress on this issues identified in #534, but some problems still remain.
The remaining problems present in TaxBrain 1.0.1 are described in the new issue #629.

Perhaps open pull requests #545 and #564 will fix some (or all) of these problems.

@MattHJensen @brittainhard @GoFroggyRun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants