refactor(SQS): convert poolmanager taker fee calc methods to functions #6821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
V:state/compatible/no_backport
p0mvn
added
A:automerge
V:state/compatible/backport
p0mvn
requested review from
czarcas7ic,
mattverse and
AlpinYukseloglu
as code owners
AlpinYukseloglu
approved these changes
Nov 5, 2023
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio refresh |
✅ Pull request refreshed |
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2023
#6821) Closes: https://app.clickup.com/t/86a1af4tp ## What is the purpose of the change This PR converts some poolmanager taker fee calc methods to functions. In #6785, these are used in SQS calculations directly. (cherry picked from commit 17aab08)
p0mvn
added a commit
that referenced
this pull request
Nov 11, 2023
#6821) (#6864) Closes: https://app.clickup.com/t/86a1af4tp ## What is the purpose of the change This PR converts some poolmanager taker fee calc methods to functions. In #6785, these are used in SQS calculations directly. (cherry picked from commit 17aab08) Co-authored-by: Roman <roman@osmosis.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: https://app.clickup.com/t/86a1af4tp
What is the purpose of the change
This PR converts some poolmanager taker fee calc methods to functions. In #6785, these are used in SQS calculations directly.