Off-chain router V20 release line #6785
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:docs
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
…nge query (#6805) Closes: https://app.clickup.com/t/86a19jj0x ## What is the purpose of the change This PR is an update to the full range liquidity query. It adds a new return parameter that is the bucket index corresponding to the current tick. This functionality is necessary for the SQS router in: #6785 By having this index, we don't have to iterate all ticks in search of the current tick. Instead, we can index into the desired bucket in constant time. ## Testing and Verifying Added unit test and also tested on localosmosis ## Documentation and Release Note - [x] Does this pull request introduce a new feature or user-facing behavior changes? - [x] Changelog entry added to `Unreleased` section of `CHANGELOG.md`? Where is the change documented? - [ ] Specification (`x/{module}/README.md`) - [ ] Osmosis documentation site - [ ] Code comments? - [ ] N/A
mergify bot
pushed a commit
that referenced
this pull request
Nov 1, 2023
…nge query (#6805) Closes: https://app.clickup.com/t/86a19jj0x ## What is the purpose of the change This PR is an update to the full range liquidity query. It adds a new return parameter that is the bucket index corresponding to the current tick. This functionality is necessary for the SQS router in: #6785 By having this index, we don't have to iterate all ticks in search of the current tick. Instead, we can index into the desired bucket in constant time. ## Testing and Verifying Added unit test and also tested on localosmosis ## Documentation and Release Note - [x] Does this pull request introduce a new feature or user-facing behavior changes? - [x] Changelog entry added to `Unreleased` section of `CHANGELOG.md`? Where is the change documented? - [ ] Specification (`x/{module}/README.md`) - [ ] Osmosis documentation site - [ ] Code comments? - [ ] N/A (cherry picked from commit 9755013)
p0mvn
added a commit
that referenced
this pull request
Nov 2, 2023
…nge query (#6805) (#6806) Closes: https://app.clickup.com/t/86a19jj0x ## What is the purpose of the change This PR is an update to the full range liquidity query. It adds a new return parameter that is the bucket index corresponding to the current tick. This functionality is necessary for the SQS router in: #6785 By having this index, we don't have to iterate all ticks in search of the current tick. Instead, we can index into the desired bucket in constant time. ## Testing and Verifying Added unit test and also tested on localosmosis ## Documentation and Release Note - [x] Does this pull request introduce a new feature or user-facing behavior changes? - [x] Changelog entry added to `Unreleased` section of `CHANGELOG.md`? Where is the change documented? - [ ] Specification (`x/{module}/README.md`) - [ ] Osmosis documentation site - [ ] Code comments? - [ ] N/A (cherry picked from commit 9755013) Co-authored-by: Roman <roman@osmosis.team>
This was referenced Nov 5, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2023
Closes: #XXX ## What is the purpose of the change This PR moves CL test helpers into the `apptesting` package so that these heleprs can be reused in SQS. This is partial transfer of #6785 where the CL apptesting suite is already in-use
mergify bot
pushed a commit
that referenced
this pull request
Nov 5, 2023
#6821) Closes: https://app.clickup.com/t/86a1af4tp ## What is the purpose of the change This PR converts some poolmanager taker fee calc methods to functions. In #6785, these are used in SQS calculations directly.
github-actions
bot
added
the
C:x/gamm
nicolaslara
reviewed
Nov 9, 2023
app/app.go
Outdated
| isIngestManagerEnabled := os.Getenv(ENV_NAME_INGEST_TYPE) == ENV_VALUE_INGESTER_SQS | ||
| app.IngestManager = ingest.NewIngestManager() | ||
| if isIngestManagerEnabled { | ||
| dbHost := os.Getenv(ENV_NAME_INGEST_SQS_DBHOST) |
There was a problem hiding this comment.
we can probably split this into a function
nicolaslara
reviewed
Nov 9, 2023
| @@ -338,9 +347,6 @@ replace ( | |||
|
|
|||
| // N.B. v0.19.5 contains a breaking change to the IAVL API | |||
| github.com/cosmos/iavl v0.19.5 => github.com/cosmos/iavl v0.19.7 | |||
|
|
|||
| // Replace PFM with a version that includes https://github.com/cosmos/ibc-apps/pull/105 | |||
| github.com/cosmos/ibc-apps/middleware/packet-forward-middleware/v4 => github.com/osmosis-labs/ibc-apps/middleware/packet-forward-middleware/v4 v4.0.0-20231023074229-4b649a9d9cee | |||
p0mvn
force-pushed
the
roman/sqs-poc-v20
branch
from
3d9358e
to
02cd400
Compare
Continuing from #6723
…nto roman/sqs-poc-v20
* Add initial struct * Add redis to go mod * Add logger to system handler * Finsih * Finish wiring ingester * Roman's comments * Change to tendermint struct, add log * Run go mod tidy * Add more logging * Allow 10 blocks * Add more log * Add more print * Add more log * Change json * use original struct * More logs * Try using diff endpoint * Use correct port * clean up
…nto roman/sqs-poc-v20
p0mvn
added a commit
that referenced
this pull request
Nov 30, 2023
* chore: CL apptesting helpers for SQS (#6822) Closes: #XXX ## What is the purpose of the change This PR moves CL test helpers into the `apptesting` package so that these heleprs can be reused in SQS. This is partial transfer of #6785 where the CL apptesting suite is already in-use (cherry picked from commit 3ac7787) # Conflicts: # x/concentrated-liquidity/keeper_test.go # x/concentrated-liquidity/lp_test.go # x/concentrated-liquidity/swaps_test.go * updates * merge conflicts --------- Co-authored-by: Roman <roman@osmosis.team>
p0mvn
force-pushed
the
roman/sqs-poc-v20
branch
from
12db782
to
d7ccd64
Compare
* refactor(SQS): app wiring and config * go mod * fix tests * makefile * update docker compose * bug fixes
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #6723
Closes: #XXX
What is the purpose of the change
Continuing from: #6723
The reason why this is made against v20 is so that we can test sqs with localosmosis mainnet state directly on the working branch