Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor/test(CL): LP methods with lower min spot price #6323

Merged
merged 14 commits into from
Sep 8, 2023
Merged

refactor/test(CL): LP methods with lower min spot price #6323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b335df5
refactor: state-compatible big decimal tick to sqrt price conversions
p0mvn Sep 5, 2023
c2af17f
updates and clean ups
p0mvn Sep 5, 2023
3e51683
lint
p0mvn Sep 5, 2023
7db80ff
refactor: breaking CL tick to sqrt price math min spot price relaxation
p0mvn Sep 5, 2023
5aec022
refactor/test(CL): CreatePosition with lower min spot price
p0mvn Sep 5, 2023
7f2f1a6
clean up
p0mvn Sep 5, 2023
6919feb
update GetTickLiquidityForFullRange query
p0mvn Sep 6, 2023
aa9c58f
fix tests
p0mvn Sep 6, 2023
e212343
withdraw position tests
p0mvn Sep 6, 2023
0ef4a5e
add to position test
p0mvn Sep 6, 2023
cd339ca
updates
p0mvn Sep 6, 2023
64d145e
updates
p0mvn Sep 6, 2023
6116ac3
clean up
p0mvn Sep 6, 2023
77494a2
Merge branch 'main' into roman/min-spot-price-lp
p0mvn Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x/concentrated-liquidity/keeper_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ import (
)

var (
// TODO: switch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be too late for this but I wonder if it would have been beneficial to have a special TODO for precision stuff to make it easier to be sure we don't miss any of these later (e.g. TODO (precision): so we can search for that when #5726 is done)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a good idea!

However, I made sure that every single one is tracked in the epic though so not worried about misses:
#5864

// DefaultMinTick to tyoes.MinInitializedTickV2 and
// DefaultMinCurrentTick to types.MinCurrentTickV2 upon
// completion of https://github.com/osmosis-labs/osmosis/issues/5726
DefaultMinTick, DefaultMaxTick = types.MinInitializedTick, types.MaxTick
DefaultMinCurrentTick = types.MinCurrentTick
DefaultLowerPrice = osmomath.NewDec(4545)
Expand Down
Loading