Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tokenfactory events #6195

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix tokenfactory events #6195

merged 2 commits into from
Aug 28, 2023

Conversation

mattverse
Copy link
Member

Closes: #6147

What is the purpose of the change

Previously token factory events were emitting wrong attribute for mintTo and burnFrom, this PR fixes it

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/{module}/README.md)
  • Osmosis documentation site
  • Code comments?
  • N/A

@czarcas7ic czarcas7ic added A:backport/v19.x backport patches to v19.x branch V:state/breaking State machine breaking PR labels Aug 28, 2023
@ValarDragon ValarDragon merged commit 89be360 into main Aug 28, 2023
1 check passed
@ValarDragon ValarDragon deleted the mattverse/attribute-fix branch August 28, 2023 02:35
mergify bot pushed a commit that referenced this pull request Aug 28, 2023
* Fix event

* Add change log, fix proto

(cherry picked from commit 89be360)
ValarDragon pushed a commit that referenced this pull request Aug 28, 2023
* Fix event

* Add change log, fix proto

(cherry picked from commit 89be360)

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
nicolaslara pushed a commit that referenced this pull request Aug 31, 2023
* Fix event

* Add change log, fix proto
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v19.x backport patches to v19.x branch C:x/tokenfactory V:state/breaking State machine breaking PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

field mint_to_address of event tf_mint incorrectly set to msg.Sender instead of msg.MintToAddress.
3 participants