Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

field mint_to_address of event tf_mint incorrectly set to msg.Sender instead of msg.MintToAddress. #6147

Closed
apollo-sturdy opened this issue Aug 24, 2023 · 1 comment · Fixed by #6195
Closed

field mint_to_address of event tf_mint incorrectly set to msg.Sender instead of msg.MintToAddress. #6147

apollo-sturdy opened this issue Aug 24, 2023 · 1 comment · Fixed by #6195
Assignees
@mattverse

Comments

@apollo-sturdy
Copy link

See: https://github.com/osmosis-labs/osmosis/blob/main/x/tokenfactory/keeper/msg_server.go#L75C63-L75C63
@mattverse mattverse self-assigned this Aug 25, 2023
@apollo-sturdy
Copy link
Author

Might also want to remove old incorrect doc comments: https://github.com/osmosis-labs/osmosis/blob/main/proto/osmosis/tokenfactory/v1beta1/tx.proto#L65C71-L65C71
For now, we only support burning from the sender account.

and

For now, we only support minting to the sender account
https://github.com/osmosis-labs/osmosis/blob/main/proto/osmosis/tokenfactory/v1beta1/tx.proto#L49C22-L49C76

@mattverse mattverse mentioned this issue Aug 28, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattverse mattverse

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tokenfactory events osmosis-labs/osmosis
2 participants
@mattverse @apollo-sturdy