Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force undelegate superfluid staking position by whitelisted address #5861

Closed
wants to merge 12 commits into from

Conversation

iboss-ptk
Copy link
Contributor

@iboss-ptk iboss-ptk commented Jul 17, 2023

#5630

What is the purpose of the change

Added new msg ForceSuperfluidUndelegate to allow whitelisted address to force undelegate from superfluid stake. Which essentially

  • deletes the connection between the lock id and the intermediary account
  • deletes the synthetic lockup associated with the lock id
  • undelegates the superfluid staking position associated with the lock id and burns the underlying osmo tokens

Testing and Verifying

This change added tests and can be verified as follows:

  • Added unit test that validates that keeper's ForceSuperfluidUndelegate function properly
  • Added unit test that validates that msg server's ForceSuperfluidUndelegate only allows whitlisted address to call
  • Extend msg test to check authz msg de/serialization

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? - This enables smart contract to write custom migration logic to superfluid locked assets
  • Changelog entry added to Unreleased section of CHANGELOG.md?

Where is the change documented?

  • Specification (x/superfluid/README.md)
  • Code comments

@iboss-ptk iboss-ptk changed the title Boss/force superfluid undelegate Force undelegate superfluid staking position by whitelisted address Jul 17, 2023
@iboss-ptk iboss-ptk added the V:state/compatible/no_backport State machine compatible PR, depends on prior breaks label Jul 20, 2023
@github-actions github-actions bot added the C:docs Improvements or additions to documentation label Jul 20, 2023
@iboss-ptk iboss-ptk added V:state/breaking State machine breaking PR and removed V:state/compatible/no_backport State machine compatible PR, depends on prior breaks labels Jul 20, 2023
@iboss-ptk iboss-ptk marked this pull request as ready for review July 20, 2023 09:07
@iboss-ptk iboss-ptk requested review from czarcas7ic, p0mvn and mattverse and removed request for stackman27 and mattverse July 20, 2023 09:08
@czarcas7ic czarcas7ic mentioned this pull request Jul 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Aug 4, 2023
@mattverse mattverse removed the Stale label Aug 7, 2023
@mattverse
Copy link
Member

Punting review for this until v17 code freeze happens

@mattverse mattverse mentioned this pull request Aug 21, 2023
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Aug 22, 2023
@mattverse mattverse removed the Stale label Aug 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Sep 6, 2023
@mattverse mattverse removed the Stale label Sep 7, 2023
@p0mvn p0mvn removed their assignment Sep 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

@github-actions github-actions bot added the Stale label Oct 7, 2023
@github-actions github-actions bot closed this Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:docs Improvements or additions to documentation C:x/superfluid Stale V:state/breaking State machine breaking PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants