-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add XCS registry permissioning and docs #4553
Conversation
This looks good to me, but we should deal with not being able to directly modify existing items. That can be another PR, and I think it can either be disallowing changes or just requiring a time delay for gov to cancel them if necessary. Same with deletions. |
|
||
### UnwrapDenom | ||
|
||
The `UnwrapDenom` query allows a caller to retrieve the denom trace for a given IBC denom and then unwrap it into its constituent coins on the originating blockchain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to expose this at all. If so we may want to change the name, as "unwrap" should refer to actually sending the message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, we really have no reason to expose this. If you agree then I can remove it here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 618a6d6
Co-authored-by: Nicolas Lara <nicolaslara@gmail.com>
…osmosis-labs/osmosis into adam/xcs-registry-perms-and-doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@czarcas7ic made some small changes when removing the unwrap query. This should be ready for merge if you don't have strong opinions about my changes
Closes: #4442
What is the purpose of the change
This PR introduces updates to the XCS Registry feature of Osmosis. The changes made in this branch aim to improve the security and usability of the XCS Registry by adding permissions and documentation.
Specifically, this branch introduces a new permission system for the XCS Registry. With these permissions, the contract admin can now restrict access to the registry, enabling them to control who can write, modify, enable, and disable the contents of the registry. This new feature enhances the security of the registry by reducing the risk of unauthorized access.
This PR also introduces a basic README.
Brief Changelog
Testing and Verifying
Modified tests to attempt to run CRUD operations on Authorized, Unauthorized, and Contract Owner addresses
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)x/<module>/spec/
) / Osmosis docs repo / not documented)