[x/stableswap]: Increase precision of osmomath BigDec to prevent stableswap CFMM precision issues #2778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
ValarDragon
reviewed
Sep 19, 2022
ValarDragon
approved these changes
Sep 19, 2022
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
This was referenced Sep 20, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2591
What is the purpose of the change
This PR (finally!) fixes all the precision-related issues we have with our stableswap CFMM. I haven't checked exact bounds yet, but our binary search solver was able to comfortably support trillion token asset pools with this change.
A large part of the diff is #2777, which this PR branches off of.
Brief Changelog
Testing and Verifying
osmomath/decimal_test.goandosmomath/int_test.goshould be up to date with the new boundsDocumentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)