-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stableswap]: Convert all core stableswap arithmetic to use BigDec
#2777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C:x/gamm
Changes, features and bugs related to the gamm module.
label
Sep 19, 2022
AlpinYukseloglu
changed the title
[stableswap]: Convert all core stableswap arithmetic to use bigdec
[stableswap]: Convert all core stableswap arithmetic to use Sep 19, 2022
BigDec
ValarDragon
approved these changes
Sep 19, 2022
ValarDragon
reviewed
Sep 19, 2022
ValarDragon
reviewed
Sep 19, 2022
p0mvn
approved these changes
Sep 19, 2022
alexanderbez
approved these changes
Sep 19, 2022
This was referenced Sep 20, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2776
What is the purpose of the change
This PR updates all core arithmetic operations in stableswap to use our
BigDec
type instead of the regularsdk.Dec
type.Brief Changelog
sdk.Dec
for internal calculations to useBigDec
sdk.Dec
toBigDec
and vice versa to ourBigDec
implementationTesting and Verifying
sdk.Dec
andBigDec
have the same precision, but this change will require more thorough testing once we increase precision bounds inBigDec
sdk.Dec
<->BigDec
only have basic sanity tests, as testing them more thoroughly requires finalizing the specific decimal precision we want forBigDec
(left for a future PR to not block this one)Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)