test(x/gamm): add liquidity event tests #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:docs
p0mvn
commented
Jul 19, 2022
p0mvn
changed the title
p0mvn
changed the title
mattverse
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
LGTM!
Nice catch on removing the existing emit event!
I do have concern over not being able to intuitively track what events are happening from the msg server layer, rather have to follow inside methods to track what events are happening, but apart from that small concern I have LGTM!
Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
…smosis into roman/gamm-add-liq-events
I think that's a good point. Let me refactor this at the very end, once I complete all the remaining gamm events. I will add this is an acceptance criteria to the #1942 |
|
I'm merging this since need to unblock further work and the change is not risky |
mergify bot
pushed a commit
that referenced
this pull request
Jul 21, 2022
* test(gamm): add liquidity events * Apply suggestions from code review * Update x/gamm/keeper/msg_server_test.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> (cherry picked from commit 4970f16) # Conflicts: # x/gamm/keeper/pool_service_test.go
p0mvn
added a commit
that referenced
this pull request
Aug 2, 2022
* test(gamm): add liquidity events * Apply suggestions from code review * Update x/gamm/keeper/msg_server_test.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
p0mvn
added a commit
that referenced
this pull request
Aug 2, 2022
* test(gamm): add liquidity events * Apply suggestions from code review * Update x/gamm/keeper/msg_server_test.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
p0mvn
added a commit
that referenced
this pull request
Aug 2, 2022
* test(gamm): add liquidity events * Apply suggestions from code review * Update x/gamm/keeper/msg_server_test.go Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com> Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #1942
What is the purpose of the change
Tests add liquidity events that should be emitted when a pool is joined.
I noticed that they were emitted twice:
I removed 1. while keeping 2.
Testing and Verifying
This change added tests
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no