x/gamm: test that swap and LP events are emitted

[p0mvn]

Background

Currently, our tests are missing assertions about events. Moreover, it seems that some of our events are missing based on #1939

Therefore, this issue is twofold:

1. Investigate if / which events are missing and restore them
2. Add assertions in tests that events are being emitted in the correct places

Acceptance Criteria

• all events are in the right places
  • swap events:
  • pool joined
  • pool exited
  • pool created
  • msg events
• consider emitting all events from the message server
• assertions in unit tests are added
• all unit tests continue to pass

[p0mvn]

I have some progress started here: https://github.com/osmosis-labs/osmosis/tree/roman/gamm-events

[p0mvn]

@mattverse following up on your comment in one of the gamm event PRs. After doing some investigation, I think we should not move the logic for emitting swap and liquidity events to the message server.

The reason is that some gamm keeper methods might be called from other modules. For example, superfluid:

osmosis/x/superfluid/keeper/unpool.go

Line 60 in 4970f16

exitedCoins, err := k.gk.ExitPool(ctx, sender, poolId, gammSharesInLock.Amount, minOutCoins)

If we were emitting events in the message server, the remove liquidity event would not be emitted. Therefore, I think it makes sense to keep the locations as is and thoroughly test.

[mattverse]

good point! Agreed 😎

[ValarDragon]

Pretty sure this got completed!