Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement Amino serialization for x/authz and x/feegrant #224

Merged
merged 5 commits into from
May 19, 2022

Commits on May 6, 2022

  1. Configuration menu
    Copy the full SHA
    d24e73d View commit details
    Browse the repository at this point in the history
  2. fix: implement Amino serialization for x/authz and x/feegrant (cosmos…

    …#11224)
    
    * fix: Add RegisterLegacyAminoCodec for authz/feegrant
    
    * add module name
    
    * Fix GetSignByes, add tests
    
    * removed module names from registered messages to match other modules
    
    * added interfaces and concrete types registration
    
    * unseal amino instances to allow external grant and authorization registration
    
    * fixed messages tests
    
    * allow to register external types into authz modulecdc
    
    * use legacy.Cdc instead of ModuleCdc inside x/authz
    
    * move the legacy.Cdc initialization outside init function
    
    * added serialization docs
    
    * Update docs/core/encoding.md
    
    Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com>
    
    * added the Ledger specification
    
    * fixed tests
    
    Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>
    2 people authored and p0mvn committed May 6, 2022
    Configuration menu
    Copy the full SHA
    6c6c5c3 View commit details
    Browse the repository at this point in the history
  3. revert: replace all ModuleCdc instances with legacy.Cdc (cosmos#11680)

    Reverts the usage of a singleton `legacy.Cdc` codec while (de)serializing `x/authz` messages.
    
    Closes: cosmos#11643
    
    ---
    
    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*
    
    I have...
    
    - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] added `!` to the type prefix if API or client breaking change
    - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
    - [ ] provided a link to the relevant issue or specification
    - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
    - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
    - [ ] added a changelog entry to `CHANGELOG.md`
    - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [ ] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed
    
    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*
    
    I have...
    
    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)
    RiccardoM authored and p0mvn committed May 6, 2022
    Configuration menu
    Copy the full SHA
    7c433d7 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. Configuration menu
    Copy the full SHA
    facc331 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Configuration menu
    Copy the full SHA
    641cf47 View commit details
    Browse the repository at this point in the history