fix: remove time.now check from authz #11129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* test: adding authz grant tests * fix TestCLITxGrantAuthorization/Invalid_expiration_time test case * comment out the test * reenable test
tac0turtle
approved these changes
Feb 7, 2022
atheeshp
approved these changes
Feb 7, 2022
amaury1093
approved these changes
Feb 7, 2022
|
|
||
| newCoins := sdk.NewCoins(sdk.NewInt64Coin("steak", 100)) | ||
| s.T().Log("verify if expired authorization is rejected") | ||
| x := &banktypes.SendAuthorization{SpendLimit: newCoins} | ||
| err := app.AuthzKeeper.SaveGrant(ctx, granterAddr, granteeAddr, x, now.Add(-1*time.Hour)) | ||
| s.Require().NoError(err) | ||
| s.Require().Error(err) |
There was a problem hiding this comment.
oh wow, it seems that tests were incorrect
amaury1093
added
the
A:automerge
| @@ -237,14 +237,20 @@ func (k Keeper) ExportGenesis(ctx sdk.Context) *authz.GenesisState { | |||
| // InitGenesis new authz genesis | |||
| func (k Keeper) InitGenesis(ctx sdk.Context, data *authz.GenesisState) { | |||
| for _, entry := range data.Authorization { | |||
| if entry.Expiration.Before(ctx.BlockTime()) { | |||
| continue | |||
| } | |||
There was a problem hiding this comment.
Why do we continue here? I think we should return an error (or panic since we can't return).
There was a problem hiding this comment.
I was thinking more about. It's OK to continue - the grant will be valid but it will be pruned immediately... I would issue warning though.
p0mvn
added a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
May 6, 2022
ValarDragon
pushed a commit
to osmosis-labs/cosmos-sdk
that referenced
this pull request
May 19, 2022
* fix: remove time.now check from authz cosmos#11129 * fix: implement Amino serialization for x/authz and x/feegrant (cosmos#11224) * fix: Add RegisterLegacyAminoCodec for authz/feegrant * add module name * Fix GetSignByes, add tests * removed module names from registered messages to match other modules * added interfaces and concrete types registration * unseal amino instances to allow external grant and authorization registration * fixed messages tests * allow to register external types into authz modulecdc * use legacy.Cdc instead of ModuleCdc inside x/authz * move the legacy.Cdc initialization outside init function * added serialization docs * Update docs/core/encoding.md Co-authored-by: Amaury <1293565+amaurym@users.noreply.github.com> * added the Ledger specification * fixed tests Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com> * revert: replace all ModuleCdc instances with legacy.Cdc (cosmos#11680) Reverts the usage of a singleton `legacy.Cdc` codec while (de)serializing `x/authz` messages. Closes: cosmos#11643 --- *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) Co-authored-by: Riccardo Montagnin <riccardo.montagnin@gmail.com> Co-authored-by: Amaury M <1293565+amaurym@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #11115
also Closes: #11050
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change