Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authz time.Now() non-determinism for v0.46 #11115

Closed
4 tasks
Tracked by #11096
amaury1093 opened this issue Feb 4, 2022 · 2 comments · Fixed by #11129
Closed
4 tasks
Tracked by #11096

Fix authz time.Now() non-determinism for v0.46 #11115

amaury1093 opened this issue Feb 4, 2022 · 2 comments · Fixed by #11129
Labels
T:Bug

Comments

@amaury1093
Copy link
Contributor

amaury1093 commented Feb 4, 2022 •
edited
Loading

Summary of Bug

A non-determinism bug was discovered and fixed a couple of months ago in v0.44 and v0.45, related to the usage of time.Now() in the state machine.

However, this bug is still present on master.

Version

b9c7fd1

Proposal

We had a fix in #10447. However, it broke sims, so we reverted it.

  • Create a new PR with the same contents as #10447.
  • Fix sims on that PR
  • MERGE

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093
Copy link
Contributor Author

@robert-zaremba should we have more eyes on this?

I remember @aleem1314 digging up some interesting stuff with simulations. @aleem1314 Do you think you could have a look here too?

This was referenced Feb 4, 2022
Merged
Closed
@amaury1093 amaury1093 added this to the v0.46 milestone Feb 4, 2022
@aleem1314 aleem1314 mentioned this issue Feb 7, 2022
Merged
19 tasks
@robert-zaremba
Copy link
Collaborator

Thanks @aleem1314 for fixing the sim tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove time.now check from authz cosmos/cosmos-sdk
2 participants
@robert-zaremba @amaury1093